No longer builds with new RGBDS

[YoshiRulz]

When updating from 0.4.1 to 0.5.2, my automated builds stop working. derivation/before/diff/after

output of manual `make` call

cd src && rgbasm -E -Wno-truncation -Wextra -Wshift-amount -p 0xff -h -o ../rtc3test.o ../src/rom.asm
error: ../src/rom.asm(12) -> header.asm(17):
    syntax error, unexpected :
error: ../src/rom.asm(12) -> header.asm(23):
    syntax error, unexpected PRINT
error: ../src/rom.asm(12) -> header.asm(60):
    Assertion failed
error: ../src/rom.asm(12) -> header.asm(73):
    Assertion failed
error: ../src/rom.asm(12) -> header.asm(92):
    Assertion failed
error: ../src/rom.asm(12) -> header.asm(223):
    Invalid address $1e for RST
error: ../src/rom.asm(12) -> header.asm(228):
    Assertion failed
error: ../src/rom.asm(15) -> main.asm(4):
    Invalid address $16 for RST
error: ../src/rom.asm(15) -> main.asm(7):
    syntax error, unexpected PRINT
error: ../src/rom.asm(15) -> main.asm(16):
    syntax error, unexpected PRINT
error: ../src/rom.asm(15) -> main.asm(21):
    Invalid address $26 for RST
error: ../src/rom.asm(15) -> main.asm(28):
    syntax error, unexpected PRINT
error: ../src/rom.asm(15) -> main.asm(31):
    Invalid address $1e for RST
error: ../src/rom.asm(15) -> main.asm(100):
    Invalid address $16 for RST
error: ../src/rom.asm(15) -> main.asm(111):
    syntax error, unexpected PRINT
error: ../src/rom.asm(15) -> main.asm(112):
    Invalid address $1e for RST
error: ../src/rom.asm(15) -> main.asm(130):
    syntax error, unexpected PRINT
error: ../src/rom.asm(15) -> main.asm(138):
    Invalid address $26 for RST
error: ../src/rom.asm(15) -> main.asm(145):
    syntax error, unexpected PRINT
error: ../src/rom.asm(15) -> main.asm(170):
    syntax error, unexpected PRINT
error: ../src/rom.asm(15) -> main.asm(175):
    Invalid address $26 for RST
error: ../src/rom.asm(15) -> main.asm(187):
    syntax error, unexpected PRINT
error: ../src/rom.asm(15) -> main.asm(195):
    syntax error, unexpected PRINT
error: ../src/rom.asm(21) -> text.asm(9):
    syntax error, unexpected PRINT
error: ../src/rom.asm(21) -> text.asm(101):
    syntax error, unexpected PRINT
error: ../src/rom.asm(21) -> text.asm(114):
    syntax error, unexpected PRINT
error: ../src/rom.asm(27) -> basic.asm(103):
    Invalid address $2e for RST
error: ../src/rom.asm(27) -> basic.asm(109):
    Invalid address $2e for RST
error: ../src/rom.asm(27) -> basic.asm(113):
    Invalid address $2e for RST
error: ../src/rom.asm(27) -> basic.asm(118):
    Invalid address $2e for RST
error: ../src/rom.asm(27) -> basic.asm(149):
    Invalid address $2e for RST
error: ../src/rom.asm(27) -> basic.asm(167):
    Invalid address $2e for RST
error: ../src/rom.asm(27) -> basic.asm(182):
    Invalid address $2e for RST
error: ../src/rom.asm(28) -> range.asm(64):
    Invalid address $2e for RST
error: ../src/rom.asm(28) -> range.asm(117):
    Invalid address $2e for RST
error: ../src/rom.asm(28) -> range.asm(142):
    Invalid address $2e for RST
error: ../src/rom.asm(28) -> range.asm(193):
    Invalid address $2e for RST
error: ../src/rom.asm(28) -> range.asm(242):
    Invalid address $2e for RST
error: Assembly aborted (38 errors)!
make: *** [Makefile:6: rtc3test.o] Error 1

[aaaaaa123456789]

Are you sure you're building the latest master?

[CasualPokePlayer]

The errors point to the Print function, which is probably conflicting with the newer PRINT command introduced in rgbds 0.5.0.

[aaaaaa123456789]

That's correct, but I was fairly certain I had fixed that... I'll check.

[CasualPokePlayer]

The develop branch has it fixed it seems, but not master.

[aaaaaa123456789]

Gotcha. I'll post a new version later. Thanks!

[YoshiRulz]

Bump—should I just switch to the develop branch? Does the resulting rom function the same?

[aaaaaa123456789]

The resulting ROM is just as functional. I'll try to remember to update to 0.6.0 this week. Thanks!

[Rangi42]

This is sufficient to build with RGBDS 0.9.0:

# Automatic NOP after HALT was removed
perl -pi -e 's/ -h / /g' Makefile
# Defining constants requires DEF
perl -pi -e 's/^(\w+\s+EQU)/DEF \1/g' src/*.asm
# Defining macros like labels was replaced
perl -pi -e 's/^(\w+):\s*MACRO/MACRO \1/g' src/*.asm
# PRINT is a keyword
perl -pi -e 's/\bPrint\b/PrintString/g' src/*.asm
# LD A, [C] was deprecated
perl -pi -e 's/ld a, \[c\]/ldh a, [c]/g' src/*.asm

However, there will still be lds which should be ldhs, since automatic ld to ldh conversion was removed.

[aaaaaa123456789]

I'll fix it later. Thank you!

[Rangi42]

This will fix the appropriate lds to ldhs:

perl -pi -e 's/ld \[r/ldh [r/g' src/*.asm
perl -pi -e 's/ldh \[r(RAMB|RAMG|RTCL)/ld [r\1/g' src/*.asm

(All such instances are of the form ld [rFOO], a; no ld a, [rFOO], no ld [hFoo], a, no capital LD [rFOO], A, etc.)

[Rangi42]

(The default output limit of 100 errors was nice for not flooding my terminal scrollback about the overcorrected ldh [rRAMB] and ldh [rRTCL]!)