Add todo comment

aabmass · aabmass · commit 0d8a64b09f10 · 2025-02-06T16:16:22.000Z
diff --git a/instrumentation-genai/opentelemetry-instrumentation-vertexai/src/opentelemetry/instrumentation/vertexai/utils.py b/instrumentation-genai/opentelemetry-instrumentation-vertexai/src/opentelemetry/instrumentation/vertexai/utils.py
@@ -157,6 +157,8 @@ def get_genai_response_attributes(
     finish_reasons: list[str] = [
         candidate.finish_reason.name for candidate in response.candidates
     ]
+    # TODO: add gen_ai.response.id once available in the python client
+    # https://github.com/open-telemetry/opentelemetry-python-contrib/issues/3246
     return {
         GenAIAttributes.GEN_AI_RESPONSE_MODEL: response.model_version,
         GenAIAttributes.GEN_AI_RESPONSE_FINISH_REASONS: finish_reasons,

Original file line number	Diff line number	Diff line change
`@@ -157,6 +157,8 @@ def get_genai_response_attributes(`
`157`	`157`	`finish_reasons: list[str] = [`
`158`	`158`	`candidate.finish_reason.name for candidate in response.candidates`
`159`	`159`	`]`
	`160`	`+ # TODO: add gen_ai.response.id once available in the python client`
	`161`	`+ # https://github.com/open-telemetry/opentelemetry-python-contrib/issues/3246`
`160`	`162`	`return {`
`161`	`163`	`GenAIAttributes.GEN_AI_RESPONSE_MODEL: response.model_version,`
`162`	`164`	`GenAIAttributes.GEN_AI_RESPONSE_FINISH_REASONS: finish_reasons,`