comments, clean up doc strings

Author: aabmass

util/opentelemetry-util-genai/src/opentelemetry/util/genai/_fsspec_upload/fsspec_hook.py

@@ -104,7 +104,7 @@ def done(future: Future[None]) -> None:
                     "fsspec upload queue is full, dropping upload %s",
                     path,
                 )
-                return
+                continue
 
             try:
                 fut = self._executor.submit(

util/opentelemetry-util-genai/src/opentelemetry/util/genai/environment_variables.py

@@ -21,8 +21,6 @@
 )
 """
 .. envvar:: OTEL_INSTRUMENTATION_GENAI_UPLOAD_HOOK
-
-The only known value is ``fsspec``, which
 """
 
 OTEL_INSTRUMENTATION_GENAI_UPLOAD_BASE_PATH = (
@@ -32,7 +30,7 @@
 .. envvar:: OTEL_INSTRUMENTATION_GENAI_UPLOAD_BASE_PATH
 
 An :func:`fsspec.open` compatible URI/path for uploading prompts and responses. Can be a local
-path like ``file:./prompts`` or a cloud storage URI such as ``gs://my_bucket``. For more
+path like ``/path/to/prompts`` or a cloud storage URI such as ``gs://my_bucket``. For more
 information, see
 
 * `Instantiate a file-system

util/opentelemetry-util-genai/tests/test_fsspec_upload.py

@@ -121,10 +121,11 @@ def test_upload_then_shutdown(self):
     def test_upload_blocked(self):
         unblock_upload = threading.Event()
 
-        def blocked_upload(*args: Any) -> None:
+        def blocked_upload(*args: Any):
             unblock_upload.wait()
+            return MagicMock()
 
-        self.mock_fsspec.open = MagicMock(wraps=blocked_upload)
+        self.mock_fsspec.open.side_effect = blocked_upload
 
         # fill the queue
         for _ in range(MAXSIZE):