review comments

Author: aabmass

util/opentelemetry-util-genai/src/opentelemetry/util/genai/_fsspec_upload/completion_hook.py

@@ -78,11 +78,9 @@ class CompletionRefs:
 UploadData = dict[str, Callable[[], JsonEncodeable]]
 
 
-def fsspec_open(
-    urlpath: str, mode: Literal["w"], *args: Any, **kwargs: Any
-) -> TextIO:
+def fsspec_open(urlpath: str, mode: Literal["w"]) -> TextIO:
     """typed wrapper around `fsspec.open`"""
-    return cast(TextIO, fsspec.open(urlpath, mode, *args, **kwargs))  # pyright: ignore[reportUnknownMemberType]
+    return cast(TextIO, fsspec.open(urlpath, mode))  # pyright: ignore[reportUnknownMemberType]
 
 
 class FsspecUploadCompletionHook(CompletionHook):
@@ -181,8 +179,10 @@ def _do_upload(
         self, path: str, json_encodeable: Callable[[], JsonEncodeable]
     ) -> None:
         if self._format == "json":
+            # output as a single line with the json messages array
             message_lines = [json_encodeable()]
         else:
+            # output as one line per message in the array
             message_lines = json_encodeable()
             # add an index for streaming readers of jsonl
             for message_idx, line in enumerate(message_lines):