Pushback v to v_list, reset v to 0 for each face, make v_list a constant reference,

Author: aabrown100-git

Code/Source/solver/trilinos_impl.cpp

@@ -951,7 +951,7 @@ void constructJacobiScaling(const double *dirW, Epetra_Vector &diagonal)
  * \param  v            coupled boundary vector
  * \param  isCoupledBC  determines if coupled resistance BC is turned on
  */
-void trilinos_bc_create_(const std::vector<Array<double>> v_list, bool &isCoupledBC)
+void trilinos_bc_create_(const std::vector<Array<double>> &v_list, bool &isCoupledBC)
 {
   //store as global to determine which matvec multiply to use in solver
   coupledBC = isCoupledBC;
@@ -1246,18 +1246,23 @@ void TrilinosLinearAlgebra::TrilinosImpl::init_dir_and_coup_neu(ComMod& com_mod,
   bool isCoupledBC = false;
 
   for (int faIn = 0; faIn < lhs.nFaces; faIn++) {
-    auto& face = lhs.face[faIn];
+    auto& face = lhs.face[faIn]; // Extract face
+    v = 0.0; // Initialize v to zero for each face
     if (face.coupledFlag) {
       isCoupledBC = true;
       int faDof = std::min(face.dof,dof);
 
+      // Compute the coupled Neumann BC vector
       for (int a = 0; a < face.nNo; a++) {
         int Ac = face.glob(a);
         for (int i = 0; i < faDof; i++) {
           v(i,Ac) = v(i,Ac) + sqrt(fabs(res(faIn))) * face.val(i,a);
         }
       }
     }
+
+    // Add the coupled Neumann BC vector to the list
+    v_list.push_back(v);
   }
 
   // Add the v vectors to global bdryVec_list

Code/Source/solver/trilinos_impl.h

@@ -201,7 +201,7 @@ class TrilinosMatVec: public virtual Epetra_Operator
    * \param v           coeff in the scalar product
    * \param isCoupledBC determines if coupled resistance BC is turned on
    */
-  void trilinos_bc_create_(const std::vector<Array<double>> v_list, bool &isCoupledBC);
+  void trilinos_bc_create_(const std::vector<Array<double>> &v_list, bool &isCoupledBC);
 
   void trilinos_doassem_(int &numNodesPerElement, const int *eqN,
           const double *lK, double *lR);