[libc++][string_view] Applied [[nodiscard]] (llvm#169010)

`[[nodiscard]]` should be applied to functions where discarding the
return value is most likely a correctness issue.
- https://libcxx.llvm.org/CodingGuidelines.html#apply-nodiscard-where-relevant

Author: H-G-Hristov