Skip to content

Commit 1e47ec9

Browse files
committed
Use biased variance computation for old ValuationResult updates
1 parent 6ff0138 commit 1e47ec9

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

src/pydvl/value/result.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -610,7 +610,11 @@ def update(self, idx: int, new_value: float) -> ValuationResult[IndexT, NameT]:
610610
except KeyError:
611611
raise IndexError(f"Index {idx} not found in ValuationResult")
612612
val, var = running_moments(
613-
self._values[pos], self._variances[pos], self._counts[pos], new_value
613+
self._values[pos],
614+
self._variances[pos],
615+
self._counts[pos],
616+
new_value,
617+
unbiased=False,
614618
)
615619
self[pos] = ValueItem(
616620
index=cast(IndexT, idx), # FIXME

0 commit comments

Comments
 (0)