Build fails from the master: `Error: The constructor Pexp_function expects 3 argument(s), but is applied here to 1 argument(s)`

[barracuda156]

--->  Building ocaml-bisect_ppx
Executing:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_macos-powerpc.org_macos-powerpc_PPCPorts_ports_ocaml_ocaml-bisect_ppx/ocaml-bisect_ppx/work/bisect_ppx-2.8.3" && /opt/local/bin/dune build -j 8 --root=/opt/local/var/macports/build/_opt_local_var_macports_sources_macos-powerpc.org_macos-powerpc_PPCPorts_ports_ocaml_ocaml-bisect_ppx/ocaml-bisect_ppx/work/bisect_ppx-2.8.3 --profile=release --ignore-promoted-rules --no-config --only-packages=bisect_ppx --default-target=@install @install 
File "src/report/main.ml", line 35, characters 20-45:
35 |   let eval_choice = Cmdliner.Term.eval_choice [@ocaml.warning "-3"]
                         ^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Unbound value Cmdliner.Term.eval_choice
File "src/ppx/instrument.ml", line 1317, characters 12-31:
1317 |           | Pexp_function cases ->
                   ^^^^^^^^^^^^^^^^^^^
Error: The constructor Pexp_function expects 3 argument(s),
       but is applied here to 1 argument(s)
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_macos-powerpc.org_macos-powerpc_PPCPorts_ports_ocaml_ocaml-bisect_ppx/ocaml-bisect_ppx/work/bisect_ppx-2.8.3" && /opt/local/bin/dune build -j 8 --root=/opt/local/var/macports/build/_opt_local_var_macports_sources_macos-powerpc.org_macos-powerpc_PPCPorts_ports_ocaml_ocaml-bisect_ppx/ocaml-bisect_ppx/work/bisect_ppx-2.8.3 --profile=release --ignore-promoted-rules --no-config --only-packages=bisect_ppx --default-target=@install @install 
Exit code: 1

[barracuda156]

This 2d8dffb fixed the first error, but not the second.

--->  Applying patches to ocaml-bisect_ppx
--->  Applying 2d8dffbbfc0c431a37319d4d9a143836c9ec542e.patch
Executing:  cd "/opt/local/var/macports/build/_opt_CatalinaPorts_ocaml_ocaml-bisect_ppx/ocaml-bisect_ppx/work/bisect_ppx-2.8.3" && /usr/bin/patch -t -N -p0 < '/opt/CatalinaPorts/ocaml/ocaml-bisect_ppx/files/2d8dffbbfc0c431a37319d4d9a143836c9ec542e.patch'
patching file Makefile
patching file bisect_ppx.opam
patching file src/report/main.ml
Hunk #2 succeeded at 281 (offset -8 lines).
Hunk #3 succeeded at 293 (offset -8 lines).
patching file test/report/send-to.t
--->  Configuring ocaml-bisect_ppx
--->  Building ocaml-bisect_ppx
Executing:  cd "/opt/local/var/macports/build/_opt_CatalinaPorts_ocaml_ocaml-bisect_ppx/ocaml-bisect_ppx/work/bisect_ppx-2.8.3" && /opt/local/bin/dune build -j 8 --root=/opt/local/var/macports/build/_opt_CatalinaPorts_ocaml_ocaml-bisect_ppx/ocaml-bisect_ppx/work/bisect_ppx-2.8.3 --profile=release --ignore-promoted-rules --no-config --only-packages=bisect_ppx --default-target=@install @install 
File "src/ppx/instrument.ml", line 1317, characters 12-31:
1317 |           | Pexp_function cases ->
                   ^^^^^^^^^^^^^^^^^^^
Error: The constructor Pexp_function expects 3 argument(s),
       but is applied here to 1 argument(s)
Command failed:  cd "/opt/local/var/macports/build/_opt_CatalinaPorts_ocaml_ocaml-bisect_ppx/ocaml-bisect_ppx/work/bisect_ppx-2.8.3" && /opt/local/bin/dune build -j 8 --root=/opt/local/var/macports/build/_opt_CatalinaPorts_ocaml_ocaml-bisect_ppx/ocaml-bisect_ppx/work/bisect_ppx-2.8.3 --profile=release --ignore-promoted-rules --no-config --only-packages=bisect_ppx --default-target=@install @install 
Exit code: 1

[barracuda156]

@aantron Could you please take a look? I tried building from the master directly, it still fails.

[aantron]

The remaining issue in master right now is caused by building against ppxlib 0.36.0 and should be fixed by #448. You should be able to build master against ppxlib 0.35.0. I'm going to close this issue in favor of continuing in #448, but please feel free to reopen if needed!