Fix Clippy lints (#37)

* Fix underconstrained type on `nx::sf::Buffer`.

The buffer type previously didn't take into account the lifetime of the referenced data, so it is easy to cause use after free in API clients or accidentally hold on to buffer references too long in server implementations.

This gives a lifetime bound to the buffer type so it (hopefully) doesn't outlive the source data or escape the server function.

* Fix clippy lints

Author: pantsman0

src/ipc/sf.rs

@@ -58,6 +58,12 @@ impl<
 
     // TODO: ensure that sizeof(T) is a multiple of size
 
+    /// Creates a `Buffer` from raw parts
+    /// 
+    /// # Safety
+    /// 
+    /// It is the caller's responsibility to ensure the lifetime of the buffer does not exceed the
+    /// inner data.
     pub const unsafe fn new<'a: 'borrow>(addr: *mut u8, size: usize) -> Self {
         Self {
             buf: addr as *mut T,
@@ -66,6 +72,12 @@ impl<
         }
     }
 
+    /// Creates a `Buffer` from a raw pointer
+    /// 
+    /// # Safety
+    /// 
+    /// It is the caller's responsibility to ensure the lifetime of the buffer does not exceed the
+    /// inner data.
     pub const unsafe fn from_ptr<'a: 'borrow>(buf: *const T, count: usize) -> Self {
         Self {
             buf: buf as *mut T,
@@ -74,6 +86,12 @@ impl<
         }
     }
 
+    /// Creates a `Buffer` from a raw pointer
+    /// 
+    /// # Safety
+    /// 
+    /// It is the caller's responsibility to ensure the lifetime of the buffer does not exceed the
+    /// inner data.
     pub const unsafe fn from_mut_ptr<'a: 'borrow>(buf: *mut T, count: usize) -> Self {
         Self {
             buf,

src/rrt0.rs

@@ -295,7 +295,7 @@ unsafe fn normal_entry(loader_mode: LoaderMode, exit_config: Option<ExitFn>) ->
     // Initialize version support
     initialize_version(hos_version_opt);
 
-    let res = unsafe { main() };
+    unsafe { main() };
 
     // unmount fs devices
     #[cfg(feature = "fs")]