Skip to content

Commit b9cc52b

Browse files
hegdevasantaaron-ang
authored andcommitted
iommu/amd: Expicitly enable CNTRL.EPHEn bit in resume path
With recent kernel, AMDGPU failed to resume after suspend on certain laptop. Sample log: ----------- Nov 14 11:52:19 Thinkbook kernel: iommu ivhd0: AMD-Vi: Event logged [ILLEGAL_DEV_TABLE_ENTRY device=0000:06:00.0 pasid=0x00000 address=0x135300000 flags=0x0080] Nov 14 11:52:19 Thinkbook kernel: AMD-Vi: DTE[0]: 7d90000000000003 Nov 14 11:52:19 Thinkbook kernel: AMD-Vi: DTE[1]: 0000100103fc0009 Nov 14 11:52:19 Thinkbook kernel: AMD-Vi: DTE[2]: 2000000117840013 Nov 14 11:52:19 Thinkbook kernel: AMD-Vi: DTE[3]: 0000000000000000 This is because in resume path, CNTRL[EPHEn] is not set. Fix this by setting CNTRL[EPHEn] to 1 in resume path if EFR[EPHSUP] is set. Note May be better approach is to save the control register in suspend path and restore it in resume path instead of trying to set indivisual bits. We will have separate patch for that. Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219499 Fixes: c4cb231 ("iommu/amd: Add support for enable/disable IOPF") Tested-by: Hamish McIntyre-Bhatty <[email protected]> Signed-off-by: Vasant Hegde <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Joerg Roedel <[email protected]>
1 parent 0a1b09e commit b9cc52b

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

drivers/iommu/amd/amd_iommu_types.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,7 @@
175175
#define CONTROL_GAM_EN 25
176176
#define CONTROL_GALOG_EN 28
177177
#define CONTROL_GAINT_EN 29
178+
#define CONTROL_EPH_EN 45
178179
#define CONTROL_XT_EN 50
179180
#define CONTROL_INTCAPXT_EN 51
180181
#define CONTROL_IRTCACHEDIS 59

drivers/iommu/amd/init.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2653,6 +2653,10 @@ static void iommu_init_flags(struct amd_iommu *iommu)
26532653

26542654
/* Set IOTLB invalidation timeout to 1s */
26552655
iommu_set_inv_tlb_timeout(iommu, CTRL_INV_TO_1S);
2656+
2657+
/* Enable Enhanced Peripheral Page Request Handling */
2658+
if (check_feature(FEATURE_EPHSUP))
2659+
iommu_feature_enable(iommu, CONTROL_EPH_EN);
26562660
}
26572661

26582662
static void iommu_apply_resume_quirks(struct amd_iommu *iommu)

0 commit comments

Comments
 (0)