Skip to content

Commit b0a0fec

Browse files
Merge pull request #90 from nexxai/simplefixes
BREAKING CHANGE: Removing unsupported runtimes
2 parents 1c79f6e + 3834c80 commit b0a0fec

File tree

3 files changed

+3
-17
lines changed

3 files changed

+3
-17
lines changed

docs/overview.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,13 @@ You can write functions in any of the following runtimes and execute them straig
1010
- Node.js 16
1111
- Node.js 14
1212
- Node.js 12
13-
- Node.js 10
1413
- Python 3.8
1514
- Python 3.7
16-
- Python 3.6
17-
- Python 2.7
1815
- Ruby 2.7
19-
- Ruby 2.5
2016
- Java 11
2117
- Java 8
2218
- Go 1.x
2319
- .NET Core 3.1
24-
- .NET Core 2.1
2520

2621
Any runtime that [Lambda supports](https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html), you can use!
2722

src/Deployment.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
namespace Hammerstone\Sidecar;
77

88
use Exception;
9+
use Illuminate\Support\Str;
910
use Hammerstone\Sidecar\Clients\LambdaClient;
1011
use Hammerstone\Sidecar\Events\AfterFunctionsActivated;
1112
use Hammerstone\Sidecar\Events\AfterFunctionsDeployed;
@@ -195,7 +196,7 @@ protected function warmLatestVersion(LambdaFunction $function)
195196
$results = Sidecar::warmSingle($function, $async = false, $version);
196197

197198
if ($warmed = count($results)) {
198-
Sidecar::log("Warmed $warmed instances.");
199+
Sidecar::log("Warmed $warmed " . Str::plural("instance", $warmed));
199200
} else {
200201
Sidecar::log('No instances warmed. If this is unexpected, confirm your `warmingConfig` method is set up correctly.');
201202
}

src/Runtime.php

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,22 +10,14 @@ abstract class Runtime
1010

1111
public const NODEJS_12 = 'nodejs12.x';
1212

13-
public const NODEJS_10 = 'nodejs10.x';
14-
1513
public const PYTHON_39 = 'python3.9';
1614

1715
public const PYTHON_38 = 'python3.8';
1816

1917
public const PYTHON_37 = 'python3.7';
2018

21-
public const PYTHON_36 = 'python3.6';
22-
23-
public const PYTHON_27 = 'python2.7';
24-
2519
public const RUBY_27 = 'ruby2.7';
26-
27-
public const RUBY_25 = 'ruby2.5';
28-
20+
2921
public const JAVA_11 = 'java11';
3022

3123
public const JAVA_8_LINUX2 = 'java8.al2';
@@ -38,7 +30,5 @@ abstract class Runtime
3830

3931
public const DOT_NET_31 = 'dotnetcore3.1';
4032

41-
public const DOT_NET_21 = 'dotnetcore2.1';
42-
4333
public const PROVIDED_AL2 = 'provided.al2';
4434
}

0 commit comments

Comments
 (0)