Build perf optimization (#114)

* shared sorting

* Webmentions map for faster lookups

* Caching images and excerpts

* Addressing copilot suggestions

Author: aarongustafson

.eleventy.js

@@ -193,73 +193,47 @@ export default async (config) => {
 	config.addCollection("links", (collectionApi) => {
 		return collectionApi.getFilteredByGlob("**/links/*.md").reverse();
 	});
+	
+	// Optimize: Use a shared sorting function to avoid duplicate sort operations
+	const sortByDateDesc = (a, b) => b.date - a.date;
+	
 	config.addCollection("talks", (collectionApi) => {
-		return (
-			collectionApi
-				.getFilteredByGlob("**/talks/*.md")
-				// sort by date - descending
-				.sort(function (a, b) {
-					return b.date - a.date;
-				})
-		);
+		return collectionApi
+			.getFilteredByGlob("**/talks/*.md")
+			.sort(sortByDateDesc);
 	});
 	config.addCollection("articles", (collectionApi) => {
-		return (
-			collectionApi
-				.getFilteredByGlob("**/articles/*.md")
-				// sort by date - descending
-				.sort(function (a, b) {
-					return b.date - a.date;
-				})
-		);
+		return collectionApi
+			.getFilteredByGlob("**/articles/*.md")
+			.sort(sortByDateDesc);
 	});
 	config.addCollection("books", (collectionApi) => {
-		return (
-			collectionApi
-				.getFilteredByGlob("**/books/*.md")
-				// sort by date - descending
-				.sort(function (a, b) {
-					return b.date - a.date;
-				})
-		);
+		return collectionApi
+			.getFilteredByGlob("**/books/*.md")
+			.sort(sortByDateDesc);
 	});
 	config.addCollection("press", (collectionApi) => {
-		return (
-			collectionApi
-				.getFilteredByGlob("**/press/*.md")
-				// sort by date - descending
-				.sort(function (a, b) {
-					return b.date - a.date;
-				})
-		);
+		return collectionApi
+			.getFilteredByGlob("**/press/*.md")
+			.sort(sortByDateDesc);
 	});
 	config.addCollection("podcasts", (collectionApi) => {
-		return (
-			collectionApi
-				.getFilteredByGlob("**/podcasts/*.md")
-				// sort by date - descending
-				.sort(function (a, b) {
-					return b.date - a.date;
-				})
-		);
+		return collectionApi
+			.getFilteredByGlob("**/podcasts/*.md")
+			.sort(sortByDateDesc);
 	});
 	config.addCollection("feedAll", (collectionApi) => {
-		return (
-			collectionApi
-				.getFilteredByGlob([
-					"**/posts/*.md",
-					"**/links/*.md",
-					"**/talks/*.md",
-					"**/articles/*.md",
-					"**/books/*.md",
-					"**/podcasts/*.md",
-					"**/press/*.md",
-				])
-				// sort by date - descending
-				.sort(function (a, b) {
-					return b.date - a.date;
-				})
-		);
+		return collectionApi
+			.getFilteredByGlob([
+				"**/posts/*.md",
+				"**/links/*.md",
+				"**/talks/*.md",
+				"**/articles/*.md",
+				"**/books/*.md",
+				"**/podcasts/*.md",
+				"**/press/*.md",
+			])
+			.sort(sortByDateDesc);
 	});
 	config.addCollection("sitemap", function (collectionApi) {
 		// get unsorted items

_11ty/filters.js

@@ -251,6 +251,27 @@ export default {
 	},
 
 	getWebmentionsForUrl: (webmentions, url, old_url) => {
+		// Use URL index if available for O(1) lookup instead of O(n) filtering
+		if (webmentions.urlIndex) {
+			const mentions = [];
+			const currentMentions = webmentions.urlIndex.get(url) || [];
+			mentions.push(...currentMentions);
+			
+			// Check old URL if provided
+			if (old_url !== "false") {
+				const oldMentions = webmentions.urlIndex.get(old_url) || [];
+				mentions.push(...oldMentions);
+			}
+			
+			// Sort by wm-id and remove duplicates
+			return mentions
+				.filter((mention, index, self) => 
+					self.findIndex(m => m["wm-id"] === mention["wm-id"]) === index
+				)
+				.sort((a, b) => a["wm-id"] - b["wm-id"]);
+		}
+		
+		// Fallback to original filtering method
 		return webmentions.children
 						.filter(entry => {
 							//console.log( entry['wm-target'], url, old_url );

src/_data/webmentions.js

@@ -21,6 +21,21 @@ const spammers = JSON.parse(fs.readFileSync(spammers_file));
 // Configuration constants for optimization
 const MAX_NAME_LENGTH = 200; // Reasonable limit for webmention names to avoid storing extremely long titles
 
+// Create URL-indexed webmentions for faster template lookups
+function createWebmentionIndex(webmentions) {
+	const index = new Map();
+	
+	webmentions.forEach(mention => {
+		const target = mention["wm-target"];
+		if (!index.has(target)) {
+			index.set(target, []);
+		}
+		index.get(target).push(mention);
+	});
+	
+	return index;
+}
+
 // Optimize webmention data to reduce memory usage
 function optimizeWebmention(mention) {
 	const optimized = {
@@ -188,15 +203,23 @@ export default async function () {
 				children: mergedChildren.map(optimizeWebmention)
 			};
 
-			return excludeSpammers(optimizedWebmentions);
+			// Filter spammers first, then create URL index
+			const cleanWebmentions = excludeSpammers(optimizedWebmentions);
+			cleanWebmentions.urlIndex = createWebmentionIndex(cleanWebmentions.children);
+			
+			return cleanWebmentions;
 		}
 	}
 
-	// Return optimized cache data
+	// Return optimized cache data with URL index for faster template lookups
 	const optimizedCache = {
 		lastFetched: cache.lastFetched,
 		children: optimizedChildren
 	};
 
-	return excludeSpammers(optimizedCache);
+	// Filter out spammers first, then create URL index with clean data
+	const cleanCache = excludeSpammers(optimizedCache);
+	cleanCache.urlIndex = createWebmentionIndex(cleanCache.children);
+	
+	return cleanCache;
 }

src/posts/posts.11tydata.js

@@ -3,6 +3,10 @@ dotenv.config();
 
 import getShareImage from "@jlengstorf/get-share-image";
 
+// Cache for generated share images to avoid regeneration
+const shareImageCache = new Map();
+const MAX_SHARE_IMAGE_CACHE_SIZE = 500; // More than enough for current site
+
 // Markdown
 import markdownIt from "markdown-it";
 import markdownit_attrs from "markdown-it-attrs";
@@ -17,6 +21,10 @@ const md = markdownIt(markdown_options)
 	.use(markdownit_attrs)
 	.use(markdownit_footnote);
 
+// Cache for processed excerpts to avoid re-processing markdown
+const excerptCache = new Map();
+const MAX_EXCERPT_CACHE_SIZE = 1000; // More than enough for current site
+
 const isDevEnv = process.env.ELEVENTY_ENV === "development";
 const todaysDate = new Date();
 
@@ -62,19 +70,34 @@ export default {
 			showPost(data) ? `/notebook/${data.page.fileSlug}/` : false,
 		excerpt: (data) => {
 			let excerpt = "";
+			let sourceText = "";
+			
 			if ("excerpt" in data.page) {
-				excerpt = md
-					.renderInline(data.page.excerpt)
-					.replace(/\[\^\d+\]/gi, "") // remove footnotes
-					.replace(/(<([^>]+)>)/gi, "") // remove HTML
-					.trim();
+				sourceText = data.page.excerpt;
 			} else if (data.description) {
+				sourceText = data.description;
+			}
+			
+			if (sourceText) {
+				// Check cache first
+				if (excerptCache.has(sourceText)) {
+					return excerptCache.get(sourceText);
+				}
+				
 				excerpt = md
-					.renderInline(data.description)
+					.renderInline(sourceText)
 					.replace(/\[\^\d+\]/gi, "") // remove footnotes
 					.replace(/(<([^>]+)>)/gi, "") // remove HTML
 					.trim();
+				
+				// Cache the processed excerpt with size limit
+				if (excerptCache.size >= MAX_EXCERPT_CACHE_SIZE) {
+					const firstKey = excerptCache.keys().next().value;
+					excerptCache.delete(firstKey);
+				}
+				excerptCache.set(sourceText, excerpt);
 			}
+			
 			return excerpt;
 		},
 		hue: (data) => {
@@ -84,7 +107,14 @@ export default {
 			if (data.hero) {
 				return `${data.site.url}${data.hero.src}`;
 			} else {
-				return getShareImage({
+				// Create cache key from title + tags to avoid regenerating identical images
+				const cacheKey = `${data.title}-${tagsToString(data.tags)}`;
+				
+				if (shareImageCache.has(cacheKey)) {
+					return shareImageCache.get(cacheKey);
+				}
+				
+				const shareImage = getShareImage({
 					cloudName: "aarongustafson",
 					imagePublicID: "share-card",
 					tagline: tagsToString(data.tags),
@@ -107,6 +137,14 @@ export default {
 					titleBottomOffset: 205,
 					textColor: "2C2825",
 				});
+				
+				// Cache with size limit
+				if (shareImageCache.size >= MAX_SHARE_IMAGE_CACHE_SIZE) {
+					const firstKey = shareImageCache.keys().next().value;
+					shareImageCache.delete(firstKey);
+				}
+				shareImageCache.set(cacheKey, shareImage);
+				return shareImage;
 			}
 		},
 	},