Merge branch 'main' into improving-resources

Author: aaronpowell

README.md

@@ -44,7 +44,7 @@ var client = await McpClientFactory.CreateAsync(new()
 });
 
 // Print the list of tools available from the server.
-await foreach (var tool in client.ListToolsAsync())
+foreach (var tool in await client.ListToolsAsync())
 {
     Console.WriteLine($"{tool.Name} ({tool.Description})");
 }

samples/AspNetCoreSseServer/Tools/SampleLlmTool.cs

@@ -10,7 +10,7 @@ namespace TestServerWithHosting.Tools;
 [McpServerToolType]
 public static class SampleLlmTool
 {
-    [McpServerTool("sampleLLM"), Description("Samples from an LLM using MCP's sampling feature")]
+    [McpServerTool(Name = "sampleLLM"), Description("Samples from an LLM using MCP's sampling feature")]
     public static async Task<string> SampleLLM(
         IMcpServer thisServer,
         [Description("The prompt to send to the LLM")] string prompt,

samples/TestServerWithHosting/Tools/SampleLlmTool.cs

@@ -10,7 +10,7 @@ namespace TestServerWithHosting.Tools;
 [McpServerToolType]
 public static class SampleLlmTool
 {
-    [McpServerTool("sampleLLM"), Description("Samples from an LLM using MCP's sampling feature")]
+    [McpServerTool(Name = "sampleLLM"), Description("Samples from an LLM using MCP's sampling feature")]
     public static async Task<string> SampleLLM(
         IMcpServer thisServer,
         [Description("The prompt to send to the LLM")] string prompt,

src/ModelContextProtocol/AIContentExtensions.cs

@@ -33,7 +33,7 @@ public static AIContent ToAIContent(this Content content)
         Throw.IfNull(content);
 
         AIContent ac;
-        if (content is { Type: "image", MimeType: not null, Data: not null })
+        if (content is { Type: "image" or "audio", MimeType: not null, Data: not null })
         {
             ac = new DataContent(Convert.FromBase64String(content.Data), content.MimeType);
         }
@@ -111,6 +111,7 @@ internal static Content ToContent(this AIContent content) =>
                 Text = textContent.Text,
                 Type = "text",
             },
+
             DataContent dataContent => new()
             {
                 Data = dataContent.GetBase64Data(),
@@ -120,6 +121,7 @@ internal static Content ToContent(this AIContent content) =>
                     dataContent.HasTopLevelMediaType("audio") ? "audio" :
                     "resource",
             },
+            
             _ => new()
             {
                 Text = JsonSerializer.Serialize(content, McpJsonUtilities.DefaultOptions.GetTypeInfo(typeof(object))),

src/ModelContextProtocol/Client/McpClient.cs

@@ -6,7 +6,6 @@
 using ModelContextProtocol.Shared;
 using ModelContextProtocol.Utils.Json;
 using Microsoft.Extensions.Logging;
-using Microsoft.Extensions.Logging.Abstractions;
 using System.Text.Json;
 
 namespace ModelContextProtocol.Client;
@@ -126,11 +125,11 @@ private async Task InitializeAsync(CancellationToken cancellationToken)
                 new JsonRpcRequest
                 {
                     Method = "initialize",
-                    Params = new
+                    Params = new InitializeRequestParams()
                     {
-                        protocolVersion = _options.ProtocolVersion,
-                        capabilities = _options.Capabilities ?? new ClientCapabilities(),
-                        clientInfo = _options.ClientInfo
+                        ProtocolVersion = _options.ProtocolVersion,
+                        Capabilities = _options.Capabilities ?? new ClientCapabilities(),
+                        ClientInfo = _options.ClientInfo
                     }
                 },
                 initializationCts.Token).ConfigureAwait(false);

src/ModelContextProtocol/Client/McpClientExtensions.cs

@@ -469,7 +469,7 @@ internal static (IList<ChatMessage> Messages, ChatOptions? Options) ToChatClient
             {
                 message.Contents.Add(new TextContent(sm.Content.Text));
             }
-            else if (sm.Content is { Type: "image", MimeType: not null, Data: not null })
+            else if (sm.Content is { Type: "image" or "audio", MimeType: not null, Data: not null })
             {
                 message.Contents.Add(new DataContent(Convert.FromBase64String(sm.Content.Data), sm.Content.MimeType));
             }
@@ -502,11 +502,11 @@ internal static CreateMessageResult ToCreateMessageResult(this ChatResponse chat
         {
             foreach (var lmc in lastMessage.Contents)
             {
-                if (lmc is DataContent dc && dc.HasTopLevelMediaType("image"))
+                if (lmc is DataContent dc && (dc.HasTopLevelMediaType("image") || dc.HasTopLevelMediaType("audio")))
                 {
                     content = new()
                     {
-                        Type = "image",
+                        Type = dc.HasTopLevelMediaType("image") ? "image" : "audio",
                         MimeType = dc.MediaType,
                         Data = dc.GetBase64Data(),
                     };

src/ModelContextProtocol/Client/McpClientTool.cs

@@ -9,22 +9,24 @@ namespace ModelContextProtocol.Client;
 public sealed class McpClientTool : AIFunction
 {
     private readonly IMcpClient _client;
-    private readonly Tool _tool;
 
     internal McpClientTool(IMcpClient client, Tool tool)
     {
         _client = client;
-        _tool = tool;
+        ProtocolTool = tool;
     }
 
+    /// <summary>Gets the protocol <see cref="Tool"/> type for this instance.</summary>
+    public Tool ProtocolTool { get; }
+
     /// <inheritdoc/>
-    public override string Name => _tool.Name;
+    public override string Name => ProtocolTool.Name;
 
     /// <inheritdoc/>
-    public override string Description => _tool.Description ?? string.Empty;
+    public override string Description => ProtocolTool.Description ?? string.Empty;
 
     /// <inheritdoc/>
-    public override JsonElement JsonSchema => _tool.InputSchema;
+    public override JsonElement JsonSchema => ProtocolTool.InputSchema;
 
     /// <inheritdoc/>
     public override JsonSerializerOptions JsonSerializerOptions => McpJsonUtilities.DefaultOptions;
@@ -37,7 +39,7 @@ internal McpClientTool(IMcpClient client, Tool tool)
             arguments as IReadOnlyDictionary<string, object?> ??
             arguments.ToDictionary();
 
-        CallToolResponse result = await _client.CallToolAsync(_tool.Name, argDict, cancellationToken).ConfigureAwait(false);
+        CallToolResponse result = await _client.CallToolAsync(ProtocolTool.Name, argDict, cancellationToken).ConfigureAwait(false);
         return JsonSerializer.SerializeToElement(result, McpJsonUtilities.JsonContext.Default.CallToolResponse);
     }
 }

src/ModelContextProtocol/Configuration/McpServerBuilderExtensions.Tools.cs

@@ -12,7 +12,9 @@ namespace ModelContextProtocol;
 /// </summary>
 public static partial class McpServerBuilderExtensions
 {
-    private const string RequiresUnreferencedCodeMessage = "This method requires dynamic lookup of method metadata and might not work in Native AOT.";
+    private const string WithToolsRequiresUnreferencedCodeMessage = 
+        $"The non-generic {nameof(WithTools)} and {nameof(WithToolsFromAssembly)} methods require dynamic lookup of method metadata" +
+        $"and may not work in Native AOT. Use the generic {nameof(WithTools)} method instead.";
 
     /// <summary>Adds <see cref="McpServerTool"/> instances to the service collection backing <paramref name="builder"/>.</summary>
     /// <typeparam name="TTool">The tool type.</typeparam>
@@ -35,14 +37,9 @@ public static partial class McpServerBuilderExtensions
         {
             if (toolMethod.GetCustomAttribute<McpServerToolAttribute>() is not null)
             {
-                if (toolMethod.IsStatic)
-                {
-                    builder.Services.AddSingleton(services => McpServerTool.Create(toolMethod, services: services));
-                }
-                else
-                {
-                    builder.Services.AddSingleton(services => McpServerTool.Create(toolMethod, typeof(TTool), services: services));
-                }
+                builder.Services.AddSingleton((Func<IServiceProvider, McpServerTool>)(toolMethod.IsStatic ?
+                    services => McpServerTool.Create(toolMethod, new McpServerToolCreateOptions() { Services = services }) :
+                    services => McpServerTool.Create(toolMethod, typeof(TTool), new() { Services = services })));
             }
         }
 
@@ -59,7 +56,7 @@ public static partial class McpServerBuilderExtensions
     /// types, where the methods are attributed as <see cref="McpServerToolAttribute"/>, and adds an <see cref="McpServerTool"/>
     /// instance for each. For instance methods, an instance will be constructed for each invocation of the tool.
     /// </remarks>
-    [RequiresUnreferencedCode(RequiresUnreferencedCodeMessage)]
+    [RequiresUnreferencedCode(WithToolsRequiresUnreferencedCodeMessage)]
     public static IMcpServerBuilder WithTools(this IMcpServerBuilder builder, params IEnumerable<Type> toolTypes)
     {
         Throw.IfNull(builder);
@@ -69,18 +66,13 @@ public static IMcpServerBuilder WithTools(this IMcpServerBuilder builder, params
         {
             if (toolType is not null)
             {
-                foreach (var method in toolType.GetMethods(BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Static | BindingFlags.Instance))
+                foreach (var toolMethod in toolType.GetMethods(BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Static | BindingFlags.Instance))
                 {
-                    if (method.GetCustomAttribute<McpServerToolAttribute>() is not null)
+                    if (toolMethod.GetCustomAttribute<McpServerToolAttribute>() is not null)
                     {
-                        if (method.IsStatic)
-                        {
-                            builder.Services.AddSingleton(services => McpServerTool.Create(method, services: services));
-                        }
-                        else
-                        {
-                            builder.Services.AddSingleton(services => McpServerTool.Create(method, toolType, services: services));
-                        }
+                        builder.Services.AddSingleton((Func<IServiceProvider, McpServerTool>)(toolMethod.IsStatic ?
+                            services => McpServerTool.Create(toolMethod, new McpServerToolCreateOptions() { Services = services }) :
+                            services => McpServerTool.Create(toolMethod, toolType, new() { Services = services })));
                     }
                 }
             }
@@ -95,7 +87,7 @@ public static IMcpServerBuilder WithTools(this IMcpServerBuilder builder, params
     /// <param name="builder">The builder instance.</param>
     /// <param name="toolAssembly">The assembly to load the types from. Null to get the current assembly</param>
     /// <exception cref="ArgumentNullException"><paramref name="builder"/> is <see langword="null"/>.</exception>
-    [RequiresUnreferencedCode(RequiresUnreferencedCodeMessage)]
+    [RequiresUnreferencedCode(WithToolsRequiresUnreferencedCodeMessage)]
     public static IMcpServerBuilder WithToolsFromAssembly(this IMcpServerBuilder builder, Assembly? toolAssembly = null)
     {
         Throw.IfNull(builder);

src/ModelContextProtocol/Configuration/McpServerOptionsSetup.cs

@@ -27,11 +27,11 @@ public void Configure(McpServerOptions options)
         // if it otherwise lacks server information.
         if (options.ServerInfo is not { } serverInfo)
         {
-            var assemblyName = (Assembly.GetEntryAssembly() ?? Assembly.GetCallingAssembly()).GetName();
+            var assemblyName = Assembly.GetEntryAssembly()?.GetName();
             options.ServerInfo = new()
             {
-                Name = assemblyName.Name ?? "McpServer",
-                Version = assemblyName.Version?.ToString() ?? "1.0.0",
+                Name = assemblyName?.Name ?? "McpServer",
+                Version = assemblyName?.Version?.ToString() ?? "1.0.0",
             };
         }