Remove ErrorLogger from renderer

It didn't make sense to have the ErrorLogger part of the renderer
interface if it was ONLY used for http.Server error handling.

We don't plan to render that information to any other renderer,
such as logging.

Insted we'll just print the errors to the CLI output using pterm.

Author: aaronvb

pkg/renderer/printer.go

@@ -2,7 +2,6 @@ package renderer
 
 import (
 	"fmt"
-	"log"
 	"os"
 	"sort"
 	"strings"
@@ -59,12 +58,6 @@ func (p *Printer) startText() string {
 	return text
 }
 
-// ErrorLogger will create a printerLog which interfaces with Logger.
-func (p *Printer) ErrorLogger() *log.Logger {
-	errorLog := log.New(&printerLog{prefix: pterm.Error}, "", p.Port)
-	return errorLog
-}
-
 // Fatal will use the Error prefix to render the error and then exit the CLI.
 func (p *Printer) Fatal(err error) {
 	p.Spinner.Stop()

pkg/renderer/printerLog.go

@@ -0,0 +1,21 @@
+package renderer
+
+import "github.com/pterm/pterm"
+
+// printerLog is our interface to Logger and accepts a pterm prefix
+type PrinterLog struct {
+	Prefix pterm.PrefixPrinter
+}
+
+// Write will be used by the function calling our printerLog.
+// If no prefix is passed, we default to Info
+func (pl *PrinterLog) Write(b []byte) (n int, err error) {
+	if pl.Prefix.Prefix.Text == "" {
+		pl.Prefix = pterm.Info
+	}
+
+	str := pl.Prefix.WithShowLineNumber(false).Sprint(string(b))
+	pterm.Println(str)
+
+	return len(str), nil
+}

pkg/renderer/printer_log.go

@@ -0,0 +1,31 @@
+package renderer
+
+import (
+	"testing"
+
+	"github.com/pterm/pterm"
+)
+
+func TestWriteDefaultPrefix(t *testing.T) {
+	pterm.DisableOutput()
+
+	pl := PrinterLog{}
+	b := []byte("foobar")
+	i, _ := pl.Write(b)
+
+	if i != 34 {
+		t.Errorf("Expected str len %d, got %d", 34, i)
+	}
+}
+
+func TestWriteErrorPrefix(t *testing.T) {
+	pterm.DisableOutput()
+
+	pl := PrinterLog{Prefix: pterm.Error}
+	b := []byte("foobar")
+	i, _ := pl.Write(b)
+
+	if i != 38 {
+		t.Errorf("Expected str len %d, got %d", 38, i)
+	}
+}

pkg/renderer/printer_log_test.go

@@ -1,8 +1,6 @@
 package renderer
 
 import (
-	"log"
-
 	"github.com/aaronvb/logrequest"
 )
 
@@ -11,10 +9,6 @@ type Renderer interface {
 	// Start is called when we start our server.
 	Start()
 
-	// ErrorLogger can be used if we need to access the logger interface.
-	// This is useful in certain cases such as the ErrorLog when using the http.Server
-	ErrorLogger() *log.Logger
-
 	// Fatal is used when we need to display a message and should always exit the CLI.
 	Fatal(error)
 

pkg/renderer/renderer.go

@@ -2,12 +2,14 @@ package server
 
 import (
 	"fmt"
+	"log"
 	"net/http"
 
 	"github.com/aaronvb/logparams"
 	"github.com/aaronvb/logrequest"
 	"github.com/aaronvb/request_hole/pkg/renderer"
 	"github.com/gorilla/mux"
+	"github.com/pterm/pterm"
 )
 
 type Http struct {
@@ -31,10 +33,11 @@ type Http struct {
 func (s *Http) Start() {
 	s.Output.Start()
 	addr := fmt.Sprintf("%s:%d", s.Addr, s.Port)
+	errorLog := log.New(&renderer.PrinterLog{Prefix: pterm.Error}, "", 0)
 
 	srv := &http.Server{
 		Addr:     addr,
-		ErrorLog: s.Output.ErrorLogger(),
+		ErrorLog: errorLog,
 		Handler:  s.routes(),
 	}
 

pkg/server/http.go

@@ -2,10 +2,8 @@ package server
 
 import (
 	"bytes"
-	"log"
 	"net/http"
 	"net/http/httptest"
-	"os"
 	"testing"
 
 	"github.com/aaronvb/logrequest"
@@ -17,10 +15,9 @@ type MockPrinter struct {
 	headers map[string][]string
 }
 
-func (mp *MockPrinter) Fatal(error)              {}
-func (mp *MockPrinter) Start()                   {}
-func (mp *MockPrinter) ErrorLogger() *log.Logger { return log.New(os.Stderr, "", 0) }
 func (mp *MockPrinter) IncomingRequest(fields logrequest.RequestFields, params string, headers map[string][]string) {
+func (mp *MockPrinter) Fatal(error) {}
+func (mp *MockPrinter) Start()      {}
 
 func (mp *MockPrinter) IncomingRequest(fields logrequest.RequestFields, params string) {
 	mp.fields = fields