feat: simulation before sending order #2774
Conversation
|
@carlos-cow is attempting to deploy a commit to the Aave Team on Vercel. A member of the Team first needs to authorize it. |
mgrabina
changed the base branch from
main
to
feat/activate-l2s-cow-coll-swap
mgrabina
merged commit d02feb9
into
aave:feat/activate-l2s-cow-coll-swap
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| method: 'eth_simulateV1', | ||
| params: [simulationPayload] as unknown[], | ||
| }); | ||
| console.log('[CoW][CollateralSwap] PreHook simulation result', result); | ||
| return true; |
There was a problem hiding this comment.
The new eth_simulateV1 check never surfaces failures: the multicall is constructed with allowFailure: true (line 197), and in the try block the result is only logged before unconditionally returning true (lines 220-224). Because aggregate3 reports per-call failures via its success flag instead of throwing when allowFailure is true, any reverting pre/post hook will still return success here and the code proceeds to post the order even in simulation-only mode. This defeats the safety gate the simulation was meant to provide and lets invalid hook sequences be sent downstream.
Useful? React with 👍 / 👎.
2 participants
General Changes
Added eth_simulateV1 before sending the order.
We override flashloan amount to the factory, min swap amount to the instance and execute both preHook and postHook through multicall3.