refactor: remove redundant initial cost transfer in LibGotchiLending

Author: Timidan

contracts/Aavegotchi/libraries/LibGotchiLending.sol

@@ -212,10 +212,6 @@ library LibGotchiLending {
         verifyAgreeGotchiLendingParams(_borrower, _listingId, _erc721TokenId, _initialCost, _period, _revenueSplit);
         // gas savings
         address lender = lending.lender;
-
-        if (lending.initialCost > 0) {
-            LibERC20.transferFrom(s.ghstContract, _borrower, lender, _initialCost);
-        }
         lending.borrower = _borrower;
         uint40 currentTime = uint40(block.timestamp);
         lending.timeAgreed = currentTime;

scripts/upgrades/base/upgrade-fixLending.ts

@@ -0,0 +1,46 @@
+import { ethers, run } from "hardhat";
+import {
+  convertFacetAndSelectorsToString,
+  DeployUpgradeTaskArgs,
+  FacetsAndAddSelectors,
+} from "../../../tasks/deployUpgrade";
+
+import { varsForNetwork } from "../../../helpers/constants";
+import { PC_WALLET } from "../../geistBridge/paths";
+
+//adds the aavegotchi status check before escrow transfers
+
+export async function upgrade() {
+  const c = await varsForNetwork(ethers);
+  const facets: FacetsAndAddSelectors[] = [
+    {
+      facetName: "GotchiLendingFacet",
+      addSelectors: [],
+      removeSelectors: [],
+    },
+  ];
+
+  const joined1 = convertFacetAndSelectorsToString(facets);
+
+  const args1: DeployUpgradeTaskArgs = {
+    diamondOwner: PC_WALLET,
+    diamondAddress: c.aavegotchiDiamond!,
+    facetsAndAddSelectors: joined1,
+    useLedger: true,
+    useRelayer: false,
+    useMultisig: false,
+    initAddress: ethers.constants.AddressZero,
+    initCalldata: "0x",
+  };
+
+  await run("deployUpgrade", args1);
+}
+
+if (require.main === module) {
+  upgrade()
+    .then(() => process.exit(0))
+    .catch((error) => {
+      console.error(error);
+      process.exit(1);
+    });
+}