Fix PHP interpret intval("1_000_000") as 1 and not 1000000

Alex Westergaard · Alex Westergaard · commit 19c3c7a63543 · 2022-08-25T11:21:05.000+02:00
diff --git a/src/Analytics.php b/src/Analytics.php
@@ -84,7 +84,7 @@ public function setUserId(string $id)
      */
     public function setTimestamp($microOrUnix)
     {
-        $secondInMicro = intval('1_000_000');
+        $secondInMicro = intval(strtr('1_000_000', ['_' => '']));
         $offsetLimit = strtotime('-3 days') * $secondInMicro;
 
         if (!is_numeric($microOrUnix)) {
diff --git a/test/AnalyticsTest.php b/test/AnalyticsTest.php
@@ -51,7 +51,7 @@ public function testTimeIsMicrotime()
 
         $arr = $this->analytics->toArray();
 
-        $this->assertTrue($arr['timestamp_micros'] > intval('1_000_000'));
+        $this->assertTrue($arr['timestamp_micros'] > intval(strtr('1_000_000', ['_' => ''])));
     }
 
     public function testExceptionIfTimeOlderThanOffsetLimit()

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ public function setUserId(string $id)`
`84`	`84`	`*/`
`85`	`85`	`public function setTimestamp($microOrUnix)`
`86`	`86`	`{`
`87`		`- $secondInMicro = intval('1_000_000');`
	`87`	`+ $secondInMicro = intval(strtr('1_000_000', ['_' => '']));`
`88`	`88`	`$offsetLimit = strtotime('-3 days') * $secondInMicro;`
`89`	`89`
`90`	`90`	`if (!is_numeric($microOrUnix)) {`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ public function testTimeIsMicrotime()`
`51`	`51`
`52`	`52`	`$arr = $this->analytics->toArray();`
`53`	`53`
`54`		`- $this->assertTrue($arr['timestamp_micros'] > intval('1_000_000'));`
	`54`	`+ $this->assertTrue($arr['timestamp_micros'] > intval(strtr('1_000_000', ['_' => ''])));`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`public function testExceptionIfTimeOlderThanOffsetLimit()`