Skip to content

Commit d5d9bd2

Browse files
author
Alex Westergaard
committed
Remove testing of Campaign parameters
1 parent 4f9f45c commit d5d9bd2

File tree

4 files changed

+0
-185
lines changed

4 files changed

+0
-185
lines changed

src/Campaign.php

Lines changed: 0 additions & 78 deletions
This file was deleted.

src/Facade/Type/CampaignType.php

Lines changed: 0 additions & 70 deletions
This file was deleted.

src/Helper/EventHelper.php

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
use AlexWestergaard\PhpGa4\Facade\Type\GtmEventType;
66
use AlexWestergaard\PhpGa4\Facade\Type\EventType;
77
use AlexWestergaard\PhpGa4\Facade\Type\DefaultEventParamsType;
8-
use AlexWestergaard\PhpGa4\Facade\Type\CampaignType;
98
use AlexWestergaard\PhpGa4\Exception\Ga4EventException;
109

1110
abstract class EventHelper extends IOHelper implements EventType
@@ -61,19 +60,6 @@ public function setEventPage(DefaultEventParamsType $page)
6160
return $this;
6261
}
6362

64-
public function setCampaign(?CampaignType $campaign)
65-
{
66-
$this->campaign = [];
67-
68-
foreach ($campaign as $tag => $val) {
69-
if (!in_array($tag, CampaignType::CAMPAIGN_VARS)) {
70-
continue;
71-
}
72-
73-
$this->campaign[$tag] = $val;
74-
}
75-
}
76-
7763
public function toArray(): array
7864
{
7965
$return = [];

test/Unit/EventTest.php

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -621,29 +621,6 @@ public function test_viewsearchresults()
621621
$this->assertNull($this->analytics->post());
622622
}
623623

624-
public function test_can_pass_campaign_parameters()
625-
{
626-
$event = new Event\PageView;
627-
628-
/** @var Event\PageView */
629-
$event = $this->populateEventByMethod($event);
630-
631-
$event->setCampaign(
632-
Campaign::new(
633-
'newsletter_category',
634-
'newsletter',
635-
'email',
636-
'Weekly Newsletter 2020w20',
637-
'continue reading here',
638-
'section1'
639-
)
640-
);
641-
642-
$this->analytics->addEvent($event);
643-
644-
$this->assertNull($this->analytics->post());
645-
}
646-
647624
public function test_throw_name_missing()
648625
{
649626
$mock = new class extends Event\Refund

0 commit comments

Comments
 (0)