Merge pull request #653 from hongriTianqi/develop

Test: 4 func. of module_base/tool_check

Author: hongriTianqi

CMakeLists.txt

@@ -252,9 +252,9 @@ function(AddTest)
   #dependencies & link library
   get_target_property(ABACUS_LINK_LIBRARIES ${ABACUS_BIN_NAME} LINK_LIBRARIES)
   target_link_libraries(${UT_TARGET} ${UT_LIBS} ${ABACUS_LINK_LIBRARIES}
-    base cell symmetry md symmetry
+    base cell symmetry md
     neighbor orb io ions lcao parallel mrrr pdiag pw ri driver
-    pthread GTest::gtest_main)
+    pthread GTest::gtest_main GTest::gmock_main)
   install(TARGETS ${UT_TARGET} DESTINATION ${CMAKE_CURRENT_BINARY_DIR}/../../../tests )
   add_test(NAME ${UT_TARGET}
     COMMAND ${UT_TARGET}

source/module_base/test/CMakeLists.txt

@@ -10,3 +10,7 @@ AddTest(
   TARGET base_complexarray
   SOURCES complexarray_test.cpp
 )
+AddTest(
+  TARGET tool_check
+  SOURCES tool_check_test.cpp
+)

source/module_base/test/tool_check_test.cpp

@@ -0,0 +1,131 @@
+#include "../tool_check.h"
+#include "gtest/gtest.h"
+#include "gmock/gmock.h"
+#include <cstdio>
+#include <fstream>
+
+/************************************************
+ *  unit test of functions in tool_check.h
+ ***********************************************/
+
+/**
+ * - Tested Function
+ *   - ModuleBase::CHECK_NAME
+ *    - check the next input from ifs is std::string
+ *
+ *   - ModuleBase::CHECK_INT
+ *    - check the next input from ifs is int
+ *
+ *   - ModuleBase::CHECK_DOUBLE
+ *    - check the next input from ifs is double
+ *
+ *   - ModuleBase::CHECK_STRING
+ *    - check the next input from ifs is string
+ *
+ * - Author: Tianqi Zhao
+ */
+
+class ToolCheckTest : public testing::Test
+{
+  protected:
+	std::ofstream ofs;
+	std::ifstream ifs;
+	// define std::string, int, double variables
+	std::string name = "abaqus";
+	int ecut = 100;
+	double occupation = 0.23;
+	std::string caltype = "nscf";
+	// quit is the swith to control performance of function
+	bool quit = false;
+	// for capturing stdout
+	std::string output = "";
+	void TearDown()
+	{
+		remove("tmp");
+	}
+
+};
+
+TEST_F(ToolCheckTest, Name)
+{
+	ofs.open("tmp");
+	// double input to check continus check function
+	ofs << name << std::endl;
+	ofs << name << std::endl;
+	ofs.close();
+	ifs.open("tmp");
+	// non-quit check
+	testing::internal::CaptureStdout();
+	ModuleBase::CHECK_NAME(ifs, "abacus", quit);
+	output = testing::internal::GetCapturedStdout();
+	EXPECT_THAT(output,testing::HasSubstr("not match"));
+	// quit check: quit = false
+	testing::internal::CaptureStdout();
+	EXPECT_DEATH(ModuleBase::CHECK_NAME(ifs, "abacus"), "");
+	output = testing::internal::GetCapturedStdout();
+	EXPECT_THAT(output,testing::HasSubstr("NOTICE"));
+	ifs.close();
+}
+
+TEST_F(ToolCheckTest, Int)
+{
+	ofs.open("tmp");
+	// double input to check continus check function
+	ofs << ecut << std::endl;
+	ofs << ecut << std::endl;
+	ofs.close();
+	ifs.open("tmp");
+	// non-quit check
+	testing::internal::CaptureStdout();
+	ModuleBase::CHECK_INT(ifs, 80, quit);
+	output = testing::internal::GetCapturedStdout();
+	EXPECT_THAT(output,testing::HasSubstr("not match"));
+	// quit check: quit = false
+	testing::internal::CaptureStdout();
+	EXPECT_DEATH(ModuleBase::CHECK_INT(ifs, 80), "");
+	output = testing::internal::GetCapturedStdout();
+	EXPECT_THAT(output,testing::HasSubstr("NOTICE"));
+	ifs.close();
+}
+
+TEST_F(ToolCheckTest, Double)
+{
+	ofs.open("tmp");
+	// double input to check continus check function
+	ofs << occupation << std::endl;
+	ofs << occupation << std::endl;
+	ofs.close();
+	ifs.open("tmp");
+	// non-quit check: quit = false
+	testing::internal::CaptureStdout();
+	ModuleBase::CHECK_DOUBLE(ifs, 0.23002, quit);
+	output = testing::internal::GetCapturedStdout();
+	EXPECT_THAT(output,testing::HasSubstr("not match"));
+	// quit check
+	testing::internal::CaptureStdout();
+	EXPECT_DEATH(ModuleBase::CHECK_DOUBLE(ifs, 0.22998), "");
+	output = testing::internal::GetCapturedStdout();
+	EXPECT_THAT(output,testing::HasSubstr("NOTICE"));
+	ifs.close();
+}
+
+TEST_F(ToolCheckTest, String)
+{
+	ofs.open("tmp");
+	// double input to check continus check function
+	ofs << caltype << std::endl;
+	ofs << caltype << std::endl;
+	ofs.close();
+	ifs.open("tmp");
+	// non-quit check: quit=false
+	testing::internal::CaptureStdout();
+	ModuleBase::CHECK_STRING(ifs, "scf", quit);
+	output = testing::internal::GetCapturedStdout();
+	EXPECT_THAT(output,testing::HasSubstr("not match"));
+	// quit check
+	testing::internal::CaptureStdout();
+	EXPECT_DEATH(ModuleBase::CHECK_STRING(ifs, "scf"), "");
+	output = testing::internal::GetCapturedStdout();
+	EXPECT_THAT(output,testing::HasSubstr("NOTICE"));
+	ifs.close();
+}

source/module_base/tool_check.cpp

@@ -51,7 +51,7 @@ void CHECK_DOUBLE(std::ifstream &ifs,const double &v,bool quit)
 	const double tiny = 1.0e-5;
 	double v_in;
 	ifs >> v_in;
-	if( (v - v_in) > tiny )
+	if( fabs(v - v_in) > tiny )
 	{
 		if(quit)
 		{
@@ -77,7 +77,7 @@ void CHECK_STRING(std::ifstream &ifs,const std::string &v,bool quit)
 		{
 			std::cout << " read in value = " << v_in << std::endl;
 			std::cout << " the value should be = " << v << std::endl;
-			WARNING_QUIT("CHECK_DOUBLE","the name of parameter wrong!");
+			WARNING_QUIT("CHECK_STRING","the name of parameter wrong!");
 		}
 		else
 		{
@@ -87,4 +87,4 @@ void CHECK_STRING(std::ifstream &ifs,const std::string &v,bool quit)
 	return;
 }
 
-}
+}