Upgrading for better code analysis

Author: abdielcs

Form/DataTransformer/MiddleClassTransformer.php

@@ -40,7 +40,7 @@ public function __construct($propertyClass, $middleClass)
      */
     public function transform($collection)
     {
-        if($collection != null){
+        if($collection !== null){
             $result = new ArrayCollection();
 
             $propertyRef = new \ReflectionClass($this->propertyClass);
@@ -72,7 +72,6 @@ public function reverseTransform($collection)
         $propertyRef = new \ReflectionClass($this->propertyClass);
         $middleRef = new \ReflectionClass($this->middleClass);
         $setMethod = 'set' . $propertyRef->getShortName();
-        $getId = 'getId';
         if ($middleRef->hasMethod($setMethod)) {
             foreach($collection as $item){
                 $middle = $middleRef->newInstance();
@@ -82,4 +81,4 @@ public function reverseTransform($collection)
         }
         return $result;
     }
-}
+}

Form/ExpandedMTMType.php Form/Type/ExpandedMTMType.phpForm/ExpandedMTMType.php renamed to Form/Type/ExpandedMTMType.php

@@ -9,7 +9,7 @@
  * file that was distributed with this source code.
  */
 
-namespace abdielcs\ExpandedCollectionBundle\Form;
+namespace abdielcs\ExpandedCollectionBundle\Form\Type;
 
 use abdielcs\ExpandedCollectionBundle\Form\DataTransformer\MiddleClassTransformer;
 use Symfony\Component\Form\AbstractType;
@@ -57,4 +57,4 @@ public function setDefaultOptions(OptionsResolverInterface $resolver)
         ));
     }
 
-}
+}

Form/ExpandedOTMType.php Form/Type/ExpandedOTMType.phpForm/ExpandedOTMType.php renamed to Form/Type/ExpandedOTMType.php

@@ -9,7 +9,7 @@
  * file that was distributed with this source code.
  */
 
-namespace abdielcs\ExpandedCollectionBundle\Form;
+namespace abdielcs\ExpandedCollectionBundle\Form\Type;
 
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\FormInterface;
@@ -73,4 +73,4 @@ public function finishView(FormView $view, FormInterface $form, array $options)
         }
     }
 
-}
+}

README.md

@@ -54,4 +54,4 @@ That's it!. Now you can start to use it.
 License
 -------
 
-This software is published under the [MIT License](LICENSE.md)
+This software is published under the [MIT License](LICENSE.md)

Resources/config/services.yml

@@ -1,6 +1,6 @@
 parameters:
-     expanded_otm.form: abdielcs\ExpandedCollectionBundle\Form\ExpandedOTMType
-     expanded_mtm.form: abdielcs\ExpandedCollectionBundle\Form\ExpandedMTMType
+     expanded_otm.form: abdielcs\ExpandedCollectionBundle\Form\Type\ExpandedOTMType
+     expanded_mtm.form: abdielcs\ExpandedCollectionBundle\Form\Type\ExpandedMTMType
 
 services:
     expanded_otm.service:

Resources/views/Form/field_string.html.twig

@@ -1 +1 @@
-{{ value|nl2br }}
+{{ value|nl2br }}

Resources/views/Form/headers.html.twig

@@ -1 +1 @@
-{{ (translation_domain is same as(false) ? field_label : field_label|trans({}, translation_domain)) | humanize }}
+{{ (translation_domain is same as(false) ? field_label : field_label|trans({}, translation_domain)) | humanize }}

composer.json

@@ -13,7 +13,7 @@
         "MIT"
     ],
     "require" : {
-        "symfony/symfony": ">=2.3"
+        "symfony/symfony": "~2.3|~3.0"
     },
     "autoload" : {
         "psr-4" : {
@@ -25,4 +25,4 @@
             "dev-master" : "0.1.x-dev"
         }
     }
-}
+}