Skip to content

Commit 5572943

Browse files
CopilotabeckDev
andcommitted
Address code review feedback: improve health check and documentation
Co-authored-by: abeckDev <8720854+abeckDev@users.noreply.github.com>
1 parent 84352ba commit 5572943

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

.github/workflows/docker-publish.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ jobs:
4444
type=semver,pattern={{version}}
4545
type=semver,pattern={{major}}.{{minor}}
4646
type=raw,value=latest,enable={{is_default_branch}}
47+
# Note: semver tags require Git tags in the format v1.2.3
4748

4849
- name: Build Docker image
4950
uses: docker/build-push-action@v6

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ ENV ASPNETCORE_URLS=http://0.0.0.0:3001
4848

4949
# Health check
5050
HEALTHCHECK --interval=30s --timeout=3s --start-period=5s --retries=3 \
51-
CMD curl -f http://localhost:3001/mcp || exit 1
51+
CMD curl -f http://localhost:3001/ || exit 1
5252

5353
# Entry point
5454
ENTRYPOINT ["dotnet", "AbeckDev.DbTimetable.Mcp.dll"]

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ Images are tagged with multiple identifiers for flexibility:
269269
Example pulling a specific version:
270270

271271
```bash
272-
docker pull ghcr.io/abeckdev/db-timetableapi-mcpserver:main-abc1234
272+
docker pull ghcr.io/abeckdev/db-timetableapi-mcpserver:main-a1b2c3d
273273
```
274274

275275
---

0 commit comments

Comments
 (0)