More suppression.

abellgithub · abellgithub · commit 0086b5509b49 · 2025-11-12T12:58:26.000-05:00
diff --git a/alg/viewshed/viewshed_executor.cpp b/alg/viewshed/viewshed_executor.cpp
@@ -21,16 +21,20 @@
 #include "progress.h"
 #include "util.h"
 
+// cppcheck-suppress-begin knownConditionTrueFalse
 namespace gdal
 {
 namespace viewshed
 {
 
+//! @cond Doxygen_Suppress
 CPLErr DummyBand::IReadBlock(int, int, void *)
 {
     return static_cast<CPLErr>(CPLE_NotSupported);
 }
 
+//! @endcond
+
 namespace
 {
 
@@ -1193,7 +1197,6 @@ bool ViewshedExecutor::run()
     return true;
 }
 
-// cppcheck-suppress knownConditionTrueFalse
 bool ViewshedExecutor::sdMode() const
 {
     // If the SD band isn't a dummy band, we're in SD mode.
@@ -1202,3 +1205,5 @@ bool ViewshedExecutor::sdMode() const
 
 }  // namespace viewshed
 }  // namespace gdal
+
+// cppcheck-suppress-end knownConditionTrueFalse

Original file line number	Diff line number	Diff line change
`@@ -21,16 +21,20 @@`
`21`	`21`	`#include "progress.h"`
`22`	`22`	`#include "util.h"`
`23`	`23`
	`24`	`+// cppcheck-suppress-begin knownConditionTrueFalse`
`24`	`25`	`namespace gdal`
`25`	`26`	`{`
`26`	`27`	`namespace viewshed`
`27`	`28`	`{`
`28`	`29`
	`30`	`+//! @cond Doxygen_Suppress`
`29`	`31`	`CPLErr DummyBand::IReadBlock(int, int, void *)`
`30`	`32`	`{`
`31`	`33`	`return static_cast<CPLErr>(CPLE_NotSupported);`
`32`	`34`	`}`
`33`	`35`
	`36`	`+//! @endcond`
	`37`	`+`
`34`	`38`	`namespace`
`35`	`39`	`{`
`36`	`40`
`@@ -1193,7 +1197,6 @@ bool ViewshedExecutor::run()`
`1193`	`1197`	`return true;`
`1194`	`1198`	`}`
`1195`	`1199`
`1196`		`-// cppcheck-suppress knownConditionTrueFalse`
`1197`	`1200`	`bool ViewshedExecutor::sdMode() const`
`1198`	`1201`	`{`
`1199`	`1202`	`// If the SD band isn't a dummy band, we're in SD mode.`
`@@ -1202,3 +1205,5 @@ bool ViewshedExecutor::sdMode() const`
`1202`	`1205`
`1203`	`1206`	`} // namespace viewshed`
`1204`	`1207`	`} // namespace gdal`
	`1208`	`+`
	`1209`	`+// cppcheck-suppress-end knownConditionTrueFalse`