Fix Coverity Scan warnings

Author: rouault

apps/gdalgetgdalpath.cpp

@@ -15,6 +15,8 @@
 #include "gdal.h"
 #include "gdalgetgdalpath.h"
 
+#include <cassert>
+
 /************************************************************************/
 /*                         GDALGetGDALPath()                            */
 /************************************************************************/
@@ -38,7 +40,7 @@ std::string GDALGetGDALPath()
 #endif
              })
         {
-            const std::string osPath =
+            std::string osPath =
                 CPLFormFilenameSafe(pszGDAL_PATH, pszProgramName, nullptr);
             if (VSIStatL(osPath.c_str(), &sStat) == 0)
                 return osPath;
@@ -83,7 +85,7 @@ std::string GDALGetGDALPath()
                     if (VSIStatL(osBinFilename.c_str(), &sStat) == 0)
                     {
                         // Case if pszLibName=/usr/lib/libgdal.so.xxx
-                        osPath = osBinFilename;
+                        osPath = std::move(osBinFilename);
                     }
                     else
                     {
@@ -96,7 +98,7 @@ std::string GDALGetGDALPath()
                         if (VSIStatL(osBinFilename.c_str(), &sStat) == 0)
                         {
                             // Case if pszLibName=/usr/lib/yyyyy/libgdal.so.xxx
-                            osPath = osBinFilename;
+                            osPath = std::move(osBinFilename);
                         }
                         else
                         {
@@ -105,7 +107,7 @@ std::string GDALGetGDALPath()
                             if (VSIStatL(osBinFilename.c_str(), &sStat) == 0)
                             {
                                 // Case if pszLibName=/path/to/build_dir/libgdal.so.xxx
-                                osPath = osBinFilename;
+                                osPath = std::move(osBinFilename);
                             }
                         }
                     }
@@ -145,7 +147,7 @@ std::string GDALGetGDALPath()
         fpOut->Read(szVersion, 1, nVersionSize);
         for (const char ch : {'\n', '\r'})
         {
-            if (szVersion[nVersionSize - 1] == ch)
+            if (nVersionSize >= 1 && szVersion[nVersionSize - 1] == ch)
             {
                 szVersion[nVersionSize - 1] = 0;
                 --nVersionSize;

ogr/ogrsf_frmts/arrow_common/ograrrowlayer.hpp

@@ -24,6 +24,7 @@
 #include "ogr_wkb.h"
 
 #include <algorithm>
+#include <cassert>
 #include <cinttypes>
 #include <limits>
 #include <string_view>
@@ -5217,6 +5218,7 @@ inline OGRErr OGRArrowLayer::IGetExtent(int iGeomField, OGREnvelope *psExtent,
                 }
                 else
                 {
+                    assert(largeArray);
                     int64_t out_length = 0;
                     const uint8_t *data =
                         largeArray->GetValue(m_nIdxInBatch, &out_length);

port/cpl_spawn.cpp

@@ -610,7 +610,7 @@ CPLSpawnAsync(int (*pfnMain)(CPL_FILE_HANDLE, CPL_FILE_HANDLE),
     int pipe_out[2] = {-1, -1};
     int pipe_err[2] = {-1, -1};
 
-    const auto ClosePipes = [pipe_in, pipe_out, pipe_err]()
+    const auto ClosePipes = [&pipe_in, &pipe_out, &pipe_err]()
     {
         for (int i = 0; i < 2; i++)
         {