Apply suggestions from code review

rouault · web-flow · commit b1b973575428 · 2025-05-25T14:30:28.000+02:00
diff --git a/apps/gdalalg_raster_viewshed.cpp b/apps/gdalalg_raster_viewshed.cpp
@@ -35,8 +35,7 @@
 
 GDALRasterViewshedAlgorithm::GDALRasterViewshedAlgorithm(bool standaloneStep)
     : GDALRasterPipelineNonNativelyStreamingAlgorithm(NAME, DESCRIPTION,
-                                                      HELP_URL, standaloneStep),
-      m_opts{}
+                                                      HELP_URL, standaloneStep)
 {
     AddArg("position", 'p', _("Observer position"), &m_observerPos)
         .AddAlias("pos")
diff --git a/apps/gdalalg_raster_viewshed.h b/apps/gdalalg_raster_viewshed.h
@@ -38,7 +38,7 @@ class GDALRasterViewshedAlgorithm /* non final */
     bool RunStep(GDALRasterPipelineStepRunContext &ctxt) override;
 
     std::vector<double> m_observerPos{};
-    gdal::viewshed::Options m_opts;
+    gdal::viewshed::Options m_opts{};
 
     std::string m_outputMode = "normal";
     int m_band = 1;
diff --git a/autotest/cpp/CMakeLists.txt b/autotest/cpp/CMakeLists.txt
@@ -421,7 +421,7 @@ endforeach ()
 
 ###
 
-gdal_gtest_target(viewshed_internal_test vit
+gdal_gtest_target(viewshed_internal_test test-viewshed-internal
     FILES
         test_viewshed_internal.cpp
         ../../alg/viewshed/viewshed.cpp

Original file line number	Diff line number	Diff line change
`@@ -35,8 +35,7 @@`
`35`	`35`
`36`	`36`	`GDALRasterViewshedAlgorithm::GDALRasterViewshedAlgorithm(bool standaloneStep)`
`37`	`37`	`: GDALRasterPipelineNonNativelyStreamingAlgorithm(NAME, DESCRIPTION,`
`38`		`- HELP_URL, standaloneStep),`
`39`		`- m_opts{}`
	`38`	`+ HELP_URL, standaloneStep)`
`40`	`39`	`{`
`41`	`40`	`AddArg("position", 'p', _("Observer position"), &m_observerPos)`
`42`	`41`	`.AddAlias("pos")`