Fix return code handling.

abellgithub · abellgithub · commit fcc0dbf22afb · 2026-01-13T18:37:31.000-05:00
diff --git a/apps/gdal_viewshed.cpp b/apps/gdal_viewshed.cpp
@@ -328,7 +328,7 @@ bool run(gdal::Options &localOpts, bool adjustCurveCoeff)
             bSuccess = oViewshed.run(
                 hBand, localOpts.bQuiet ? GDALDummyProgress : GDALTermProgress);
         std::unique_ptr<GDALDataset> dstDs = oViewshed.output();
-        bSuccess = (dstDs->Close() == CE_None);
+        bSuccess = bSuccess && (dstDs->Close() == CE_None);
     }
     return bSuccess;
 }

Original file line number	Diff line number	Diff line change
`@@ -328,7 +328,7 @@ bool run(gdal::Options &localOpts, bool adjustCurveCoeff)`
`328`	`328`	`bSuccess = oViewshed.run(`
`329`	`329`	`hBand, localOpts.bQuiet ? GDALDummyProgress : GDALTermProgress);`
`330`	`330`	`std::unique_ptr<GDALDataset> dstDs = oViewshed.output();`
`331`		`- bSuccess = (dstDs->Close() == CE_None);`
	`331`	`+ bSuccess = bSuccess && (dstDs->Close() == CE_None);`
`332`	`332`	`}`
`333`	`333`	`return bSuccess;`
`334`	`334`	`}`