remove other flush function as well

Author: abhina-sree

llvm/include/llvm/Support/CharSet.h

@@ -62,7 +62,6 @@ class CharSetConverterImplBase {
   /// If the destination character set is a stateful character set,
   /// set the shift state to the initial state.
   /// Otherwise this is a no-op.
-  virtual std::error_code flush() const = 0;
 };
 } // namespace details
 
@@ -135,8 +134,6 @@ class CharSetConverter {
       return std::string(Result);
     return EC;
   }
-
-  std::error_code flush() const { return Converter->flush(); }
 };
 
 } // namespace llvm

llvm/lib/Support/CharSet.cpp

@@ -90,7 +90,6 @@ class CharSetConverterTable : public details::CharSetConverterImplBase {
 
   std::error_code convert(StringRef Source, SmallVectorImpl<char> &Result,
                           bool ShouldAutoFlush) const override;
-  std::error_code flush() const override;
 };
 
 std::error_code CharSetConverterTable::convert(StringRef Source,
@@ -106,10 +105,6 @@ std::error_code CharSetConverterTable::convert(StringRef Source,
   return std::error_code();
 }
 
-std::error_code CharSetConverterTable::flush() const {
-  return std::error_code();
-}
-
 #ifdef HAVE_ICU
 class CharSetConverterICU : public details::CharSetConverterImplBase {
   UConverter *FromConvDesc;
@@ -137,7 +132,6 @@ class CharSetConverterICU : public details::CharSetConverterImplBase {
 
   std::error_code convert(StringRef Source, SmallVectorImpl<char> &Result,
                           bool ShouldAutoFlush) const override;
-  std::error_code flush() const override;
 };
 
 std::error_code CharSetConverterICU::convert(StringRef Source,
@@ -180,8 +174,6 @@ std::error_code CharSetConverterICU::convert(StringRef Source,
   return std::error_code();
 }
 
-std::error_code CharSetConverterICU::flush() const { return std::error_code(); }
-
 #elif defined(HAVE_ICONV)
 class CharSetConverterIconv : public details::CharSetConverterImplBase {
   iconv_t ConvDesc;
@@ -191,7 +183,6 @@ class CharSetConverterIconv : public details::CharSetConverterImplBase {
 
   std::error_code convert(StringRef Source, SmallVectorImpl<char> &Result,
                           bool ShouldAutoFlush) const override;
-  std::error_code flush() const override;
 };
 
 std::error_code CharSetConverterIconv::convert(StringRef Source,
@@ -243,14 +234,6 @@ std::error_code CharSetConverterIconv::convert(StringRef Source,
   return std::error_code();
 }
 
-std::error_code CharSetConverterIconv::flush() const {
-  size_t Ret = iconv(ConvDesc, nullptr, nullptr, nullptr, nullptr);
-  if (Ret == static_cast<size_t>(-1)) {
-    return std::error_code(errno, std::generic_category());
-  }
-  return std::error_code();
-}
-
 #endif // HAVE_ICONV
 } // namespace