Reviewer for drafts

[hrach]

Currently, the reviewer is also set on draft MR (gitlab). I can use both approaches, but I don't want to ask for a review of the draft in every MR. Could this be an option/question after picking Draft?

Also, the reviewer is reset - I would expect setting up reviewers mostly when creating an MR.

Anyway, I love those changes (assignee/reviewer support). Thx!

[abhinav]

Deferring reviews until draft is lifted makes sense as a feature. Will add (if someone else doesn't).

Also, the reviewer is reset - I would expect setting up reviewers mostly when creating an MR.

Oh, that's absolutely a bug. It should only append, not remove. I'll look into that.

[hrach]

Oh, that's absolutely a bug. It should only append, not remove. I'll look into that.

I mean it that it is added even though I removed it (for the draft PR).

[abhinav]

I mean it that it is added even though I removed it (for the draft PR).

Oh, could you clarify the setup please?
Are the reviewers set in configuration or as flags?

If they're set in configuration, git-spice will always make sure they're on the submitted CRs—whether it's new or updated.
This may be something worth making configurable as well, but the current behavior is requested reviewers, assignees, and labels are a "set" operation — ensure they're present on the CR whether it's new or pre-existing.

[abhinav]

"don't add reviewers for draft PRs" functionality is out now as part of v0.23.
Hopefully that covers your use cases.