Skip to content

Commit 1a0e5c6

Browse files
abhinavminhasabhinavminhas
committed
Code Quality - Remove or correct this assertion
1 parent 96c43ca commit 1a0e5c6

File tree

4 files changed

+20
-20
lines changed

4 files changed

+20
-20
lines changed

‎QueryDB.Core.Tests/MSSQLTests.cs‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -503,7 +503,7 @@ public void Test_MSSQL_ExecuteTransaction_DDL_Multiple_Queries()
503503
};
504504
var dbContext = new DBContext(DB.MSSQL, MSSQLConnectionString);
505505
var result = dbContext.ExecuteTransaction(statements);
506-
Assert.AreEqual(true, result);
506+
Assert.IsTrue(result);
507507

508508
var tableCount = dbContext
509509
.FetchData(string.Format(dDLExecutionCheckSql, "dbo", "Employee"));
@@ -516,7 +516,7 @@ public void Test_MSSQL_ExecuteTransaction_DDL_Multiple_Queries()
516516
dropTableSql
517517
};
518518
result = dbContext.ExecuteTransaction(statements);
519-
Assert.AreEqual(true, result);
519+
Assert.IsTrue(result);
520520

521521
tableCount = dbContext
522522
.FetchData(string.Format(dDLExecutionCheckSql, "dbo", "Employees"));
@@ -541,7 +541,7 @@ public void Test_MSSQL_ExecuteTransaction_DML_Multiple_Queries()
541541

542542
// Insert & Update
543543
var result = dbContext.ExecuteTransaction(statements);
544-
Assert.AreEqual(true, result);
544+
Assert.IsTrue(result);
545545
var data = dbContext.FetchData(verifyDMLExecution);
546546
Assert.IsTrue(data.Count == 1);
547547
var agent = data.FirstOrDefault();
@@ -558,7 +558,7 @@ public void Test_MSSQL_ExecuteTransaction_DML_Multiple_Queries()
558558
deleteSql
559559
};
560560
result = dbContext.ExecuteTransaction(statements);
561-
Assert.AreEqual(true, result);
561+
Assert.IsTrue(result);
562562
data = dbContext.FetchData(verifyDMLExecution);
563563
Assert.IsTrue(data.Count == 0);
564564
}
@@ -582,7 +582,7 @@ public void Test_MSSQL_ExecuteTransaction_Incomplete_Transaction_Rollback_On_Err
582582

583583
// Insert & Update
584584
var result = dbContext.ExecuteTransaction(statements);
585-
Assert.AreEqual(false, result);
585+
Assert.IsFalse(result);
586586
var data = dbContext.FetchData(verifyDMLExecution);
587587
Assert.IsTrue(data.Count == 0);
588588
}

‎QueryDB.Core.Tests/MySQLTests.cs‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -475,7 +475,7 @@ public void Test_MySQL_ExecuteTransaction_DDL_Multiple_Queries()
475475
};
476476
var dbContext = new DBContext(DB.MySQL, MySQLConnectionString);
477477
var result = dbContext.ExecuteTransaction(statements);
478-
Assert.AreEqual(true, result);
478+
Assert.IsTrue(result);
479479

480480
var tableCount = dbContext
481481
.FetchData(string.Format(dDLExecutionCheckSql, "mysql", "Employee"));
@@ -488,7 +488,7 @@ public void Test_MySQL_ExecuteTransaction_DDL_Multiple_Queries()
488488
dropTableSql
489489
};
490490
result = dbContext.ExecuteTransaction(statements);
491-
Assert.AreEqual(true, result);
491+
Assert.IsTrue(result);
492492

493493
tableCount = dbContext
494494
.FetchData(string.Format(dDLExecutionCheckSql, "mysql", "Employees"));
@@ -513,7 +513,7 @@ public void Test_MySQL_ExecuteTransaction_DML_Multiple_Queries()
513513

514514
// Insert & Update
515515
var result = dbContext.ExecuteTransaction(statements);
516-
Assert.AreEqual(true, result);
516+
Assert.IsTrue(result);
517517
var data = dbContext.FetchData(verifyDMLExecution);
518518
Assert.IsTrue(data.Count == 1);
519519
var agent = data.FirstOrDefault();
@@ -530,7 +530,7 @@ public void Test_MySQL_ExecuteTransaction_DML_Multiple_Queries()
530530
deleteSql
531531
};
532532
result = dbContext.ExecuteTransaction(statements);
533-
Assert.AreEqual(true, result);
533+
Assert.IsTrue(result);
534534
data = dbContext.FetchData(verifyDMLExecution);
535535
Assert.IsTrue(data.Count == 0);
536536
}
@@ -554,7 +554,7 @@ public void Test_MySQL_ExecuteTransaction_Incomplete_Transaction_Rollback_On_Err
554554

555555
// Insert & Update
556556
var result = dbContext.ExecuteTransaction(statements);
557-
Assert.AreEqual(false, result);
557+
Assert.IsFalse(result);
558558
var data = dbContext.FetchData(verifyDMLExecution);
559559
Assert.IsTrue(data.Count == 0);
560560
}

‎QueryDB.Core.Tests/OracleTests.cs‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -486,7 +486,7 @@ public void Test_Oracle_ExecuteTransaction_DDL_Multiple_Queries()
486486
};
487487
var dbContext = new DBContext(DB.Oracle, OracleConnectionString);
488488
var result = dbContext.ExecuteTransaction(statements);
489-
Assert.AreEqual(true, result);
489+
Assert.IsTrue(result);
490490

491491
var tableCount = dbContext
492492
.FetchData(string.Format(dDLExecutionCheckSql, "Employee"));
@@ -499,7 +499,7 @@ public void Test_Oracle_ExecuteTransaction_DDL_Multiple_Queries()
499499
dropTableSql
500500
};
501501
result = dbContext.ExecuteTransaction(statements);
502-
Assert.AreEqual(true, result);
502+
Assert.IsTrue(result);
503503

504504
tableCount = dbContext
505505
.FetchData(string.Format(dDLExecutionCheckSql, "Employees"));
@@ -524,7 +524,7 @@ public void Test_Oracle_ExecuteTransaction_DML_Multiple_Queries()
524524

525525
// Insert & Update
526526
var result = dbContext.ExecuteTransaction(statements);
527-
Assert.AreEqual(true, result);
527+
Assert.IsTrue(result);
528528
var data = dbContext.FetchData(verifyDMLExecution);
529529
Assert.IsTrue(data.Count == 1);
530530
var agent = data.FirstOrDefault();
@@ -541,7 +541,7 @@ public void Test_Oracle_ExecuteTransaction_DML_Multiple_Queries()
541541
deleteSql
542542
};
543543
result = dbContext.ExecuteTransaction(statements);
544-
Assert.AreEqual(true, result);
544+
Assert.IsTrue(result);
545545
data = dbContext.FetchData(verifyDMLExecution);
546546
Assert.IsTrue(data.Count == 0);
547547
}
@@ -565,7 +565,7 @@ public void Test_Oracle_ExecuteTransaction_Incomplete_Transaction_Rollback_On_Er
565565

566566
// Insert & Update
567567
var result = dbContext.ExecuteTransaction(statements);
568-
Assert.AreEqual(false, result);
568+
Assert.IsFalse(result);
569569
var data = dbContext.FetchData(verifyDMLExecution);
570570
Assert.IsTrue(data.Count == 0);
571571
}

‎QueryDB.Core.Tests/PostgreSQLTests.cs‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -469,7 +469,7 @@ public void Test_PostgreSQL_ExecuteTransaction_DDL_Multiple_Queries()
469469
};
470470
var dbContext = new DBContext(DB.PostgreSQL, PostgreSQLConnectionString);
471471
var result = dbContext.ExecuteTransaction(statements);
472-
Assert.AreEqual(true, result);
472+
Assert.IsTrue(result);
473473

474474
var tableCount = dbContext
475475
.FetchData(string.Format(dDLExecutionCheckSql, "public", "Employee"));
@@ -482,7 +482,7 @@ public void Test_PostgreSQL_ExecuteTransaction_DDL_Multiple_Queries()
482482
dropTableSql
483483
};
484484
result = dbContext.ExecuteTransaction(statements);
485-
Assert.AreEqual(true, result);
485+
Assert.IsTrue(result);
486486

487487
tableCount = dbContext
488488
.FetchData(string.Format(dDLExecutionCheckSql, "public", "Employees"));
@@ -507,7 +507,7 @@ public void Test_PostgreSQL_ExecuteTransaction_DML_Multiple_Queries()
507507

508508
// Insert & Update
509509
var result = dbContext.ExecuteTransaction(statements);
510-
Assert.AreEqual(true, result);
510+
Assert.IsTrue(result);
511511
var data = dbContext.FetchData(verifyDMLExecution);
512512
Assert.IsTrue(data.Count == 1);
513513
var agent = data.FirstOrDefault();
@@ -524,7 +524,7 @@ public void Test_PostgreSQL_ExecuteTransaction_DML_Multiple_Queries()
524524
deleteSql
525525
};
526526
result = dbContext.ExecuteTransaction(statements);
527-
Assert.AreEqual(true, result);
527+
Assert.IsTrue(result);
528528
data = dbContext.FetchData(verifyDMLExecution);
529529
Assert.IsTrue(data.Count == 0);
530530
}
@@ -548,7 +548,7 @@ public void Test_PostgreSQL_ExecuteTransaction_Incomplete_Transaction_Rollback_O
548548

549549
// Insert & Update
550550
var result = dbContext.ExecuteTransaction(statements);
551-
Assert.AreEqual(false, result);
551+
Assert.IsFalse(result);
552552
var data = dbContext.FetchData(verifyDMLExecution);
553553
Assert.IsTrue(data.Count == 0);
554554
}

0 commit comments

Comments
 (0)