Code Quality - Simplified loop using the Any LINQ method

abhinavminhas · abhinavminhas · commit c195fc0b317a · 2025-02-09T13:14:54.000+11:00
diff --git a/QueryDB/DBContext.cs b/QueryDB/DBContext.cs
@@ -201,11 +201,10 @@ public int ExecuteCommand(string sqlStatement)
         /// </returns>
         public bool ExecuteTransaction(List<string> sqlStatements)
         {
-            foreach(var sqlStatement in sqlStatements.Where(sqlStatement => Regex.IsMatch(sqlStatement, "^\\s*SELECT\\s+.*", RegexOptions.IgnoreCase | RegexOptions.Singleline, TimeSpan.FromSeconds(5))))
-            {
+            var selectExists = sqlStatements.Any(sqlStatement => Regex.IsMatch(sqlStatement, "^\\s*SELECT\\s+.*", RegexOptions.IgnoreCase | RegexOptions.Singleline, TimeSpan.FromSeconds(5)));
+            if (selectExists)
                 throw new QueryDBException(QueryDBExceptions.ErrorMessage.UnsupportedSelectExecuteTransaction,
                     QueryDBExceptions.ErrorType.UnsupportedCommand, QueryDBExceptions.AdditionalInfo.UnsupportedSelectExecuteTransaction);
-            }
             if (Database.Equals(DB.MSSQL))
             {
                 using (var msSqlDBConnection = GetSqlServerConnection())

Original file line number	Diff line number	Diff line change
`@@ -201,11 +201,10 @@ public int ExecuteCommand(string sqlStatement)`
`201`	`201`	`/// </returns>`
`202`	`202`	`public bool ExecuteTransaction(List<string> sqlStatements)`
`203`	`203`	`{`
`204`		`- foreach(var sqlStatement in sqlStatements.Where(sqlStatement => Regex.IsMatch(sqlStatement, "^\\sSELECT\\s+.", RegexOptions.IgnoreCase \| RegexOptions.Singleline, TimeSpan.FromSeconds(5))))`
`205`		`- {`
	`204`	`+ var selectExists = sqlStatements.Any(sqlStatement => Regex.IsMatch(sqlStatement, "^\\sSELECT\\s+.", RegexOptions.IgnoreCase \| RegexOptions.Singleline, TimeSpan.FromSeconds(5)));`
	`205`	`+ if (selectExists)`
`206`	`206`	`throw new QueryDBException(QueryDBExceptions.ErrorMessage.UnsupportedSelectExecuteTransaction,`
`207`	`207`	`QueryDBExceptions.ErrorType.UnsupportedCommand, QueryDBExceptions.AdditionalInfo.UnsupportedSelectExecuteTransaction);`
`208`		`- }`
`209`	`208`	`if (Database.Equals(DB.MSSQL))`
`210`	`209`	`{`
`211`	`210`	`using (var msSqlDBConnection = GetSqlServerConnection())`