Skip to content

Commit 29ad247

Browse files
committed
bring back VERIFIED6
1 parent afe2e62 commit 29ad247

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

proxy/http/server/reverse.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
from proxy.core.base import TcpUpstreamConnectionHandler
1818
from proxy.http.parser import HttpParser
1919
from proxy.http.server import HttpWebServerBasePlugin
20-
from proxy.common.utils import text_
20+
from proxy.common.utils import text_, bytes_
2121
from proxy.http.exception import HttpProtocolException
2222
from proxy.common.constants import (
2323
COLON, HTTP_PROTO, HTTPS_PROTO, DEFAULT_HTTP_PORT, DEFAULT_HTTPS_PORT,
@@ -130,9 +130,9 @@ def handle_request(self, request: HttpParser) -> None:
130130
request.build(
131131
host=self.choice.hostname
132132
+ (
133-
COLON + self.choice.port.to_bytes()
133+
COLON + bytes_(self.choice.port)
134134
if self.choice.port is not None
135-
else b''
135+
else b""
136136
),
137137
),
138138
),

tests/integration/test_integration.sh

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -174,8 +174,5 @@ RESPONSE=$($CMD 2> /dev/null)
174174
verify_contains "$RESPONSE" "$REVERSE_PROXY_RESPONSE"
175175
VERIFIED6=$?
176176

177-
# FIXME: VERIFIED6 NOT ASSERTED BECAUSE WE STARTED GETTING EMPTY RESPONSE FROM UPSTREAM
178-
# AFTER CHANGE FROM HTTPBIN TO HTTPBINGO. This test works and passes perfectly when
179-
# run from a local system
180-
EXIT_CODE=$(( $VERIFIED1 || $VERIFIED2 || $VERIFIED3 || $VERIFIED4 || $VERIFIED5 ))
177+
EXIT_CODE=$(( $VERIFIED1 || $VERIFIED2 || $VERIFIED3 || $VERIFIED4 || $VERIFIED5 || $VERIFIED6 ))
181178
exit $EXIT_CODE

0 commit comments

Comments
 (0)