fix(companieshouseapi): #346 update the gov companieshouse url in config

fix(build.gradle): #346 revert logback 1.5.13 version to fix parse error

Author: abhisheksr01

.github/dependabot.yml

@@ -12,4 +12,4 @@ updates:
     open-pull-requests-limit: 10
     commit-message:
       prefix: ci
-      include: scope
+      include: scope

build.gradle

@@ -37,15 +37,6 @@ dependencies {
     implementation 'org.springframework.boot:spring-boot-starter-web'
     implementation 'org.springframework.boot:spring-boot-starter-actuator'
     testImplementation('org.springframework.boot:spring-boot-starter-test')
-    // Upgrade transient vulnerabilities to fix vulnerabilities
-    configurations.all {
-        resolutionStrategy.eachDependency { DependencyResolveDetails details ->
-            // https://docs.gradle.org/current/userguide/resolution_rules.html
-            if (details.requested.group == 'ch.qos.logback' && details.requested.name == 'logback-classic') {
-                details.useVersion '1.5.13'
-            }
-        }
-    }
     // Cucumber Dependencies for BDD
     testImplementation "io.cucumber:cucumber-java:${ioCucumberVersion}"
     testImplementation "io.cucumber:cucumber-junit:${ioCucumberVersion}"

src/main/java/com/uk/companieshouse/connector/CompaniesHouseConnector.java

@@ -33,7 +33,7 @@ public CompaniesHouseGovUKResponse getCompaniesHouseDetails(String crn) {
         restTemplate.getInterceptors().add(
                 new BasicAuthenticationInterceptor(authUsername, ""));
 
-        log.debug("CompaniesHouseConnector:getCompaniesHouseDetails: Make External call to {} with CRN {}",
+        log.debug("CompaniesHouseConnector:getCompaniesHouseDetails: Make External call to: {} with CRN: {}",
                 govCompaniesHouseEndpoint, crn);
         ResponseEntity<CompaniesHouseGovUKResponse> responseEntity = restTemplate
                 .getForEntity(govCompaniesHouseEndpoint, CompaniesHouseGovUKResponse.class, crn);

src/main/resources/application.yaml

@@ -19,5 +19,5 @@ logging:
         companieshouse: DEBUG
 
 govCompaniesHouse:
-  endpoint: https://api.companieshouse.gov.uk/search/companies?q={companyRef}
+  endpoint: https://api.company-information.service.gov.uk/search/companies?q={crn}
   authUserName: dummy-auth-user