refact: fix last refactoring

Author: sfermigier

demos/lib/phases.py

@@ -67,6 +67,22 @@ def run_prerequisites(ctx: DemoContext) -> bool:
     phase_start = time.time()
 
     try:
+        # For Docker backend, always set up the container first (regardless of --preflight)
+        # This is required because Docker backend needs to create/start the container
+        # before any other operations can run.
+        if ctx.backend == "docker" and not ctx.preflight:
+            from lib.commands import CommandError as CmdError
+
+            backend = ctx.get_backend()
+            print_step("Setting up Docker container...")
+            step_start = time.time()
+            if not backend.setup():
+                print_error("Failed to set up Docker container")
+                raise CmdError("Docker container setup failed")
+            record_timing("docker_setup", time.time() - step_start, category="setup")
+            print_success(f"Docker container '{ctx.docker_container}' ready")
+            pause(ctx.pause_between_steps)
+
         # Preflight checks (only with --preflight)
         if ctx.preflight:
             step_start = time.time()

packages/hop3-installer/src/hop3_installer/server_installer/postgres.py

@@ -31,9 +31,16 @@ def _start_postgres_service(distro: str) -> bool:
     # Initialize PostgreSQL on Fedora (required before first start)
     if distro == "fedora":
         if not Path("/var/lib/pgsql/data/pg_hba.conf").exists():
-            run_cmd(["postgresql-setup", "--initdb"], check=False)
+            result = run_cmd(["postgresql-setup", "--initdb"], check=False)
+            if result.returncode != 0:
+                print_warning("PostgreSQL initialization failed")
+                if result.stderr:
+                    print_detail(result.stderr[:200])
+
+    result = run_cmd(["systemctl", "enable", "postgresql"], check=False)
+    if result.returncode != 0:
+        print_warning("Failed to enable PostgreSQL service")
 
-    run_cmd(["systemctl", "enable", "postgresql"], check=False)
     result = run_cmd(["systemctl", "start", "postgresql"], check=False)
 
     if result.returncode != 0:
@@ -139,7 +146,10 @@ def setup_postgres(config: ServerInstallerConfig, distro: str) -> str | None:
     print_success("PostgreSQL service started")
 
     # Create role and database
-    _create_postgres_role_and_db()
+    if not _create_postgres_role_and_db():
+        print_warning(
+            "PostgreSQL role/database creation had issues - continuing anyway"
+        )
 
     # Set superuser password
     pg_password = _set_postgres_password()

packages/hop3-installer/src/hop3_installer/server_installer/user.py

@@ -10,7 +10,7 @@
 import subprocess  # noqa: TC003
 from pathlib import Path
 
-from hop3_installer.common import print_info, print_success, run_cmd
+from hop3_installer.common import print_info, print_success, print_warning, run_cmd
 
 from .config import HOME_DIR, HOP3_GROUP, HOP3_USER
 
@@ -74,7 +74,12 @@ def create_user_and_group() -> None:
     os.chown(HOME_DIR, hop3_uid, hop3_gid)
     Path(HOME_DIR).chmod(0o755)
 
-    # Add www-data to hop3 group
+    # Add www-data to hop3 group (needed for nginx to access app sockets)
     if user_exists("www-data"):
-        run_cmd(["usermod", "-a", "-G", HOP3_GROUP, "www-data"], check=False)
-        print_info("Added www-data to hop3 group")
+        result = run_cmd(["usermod", "-a", "-G", HOP3_GROUP, "www-data"], check=False)
+        if result.returncode == 0:
+            print_info("Added www-data to hop3 group")
+        else:
+            print_warning(
+                "Failed to add www-data to hop3 group - nginx may have permission issues"
+            )