Merge pull request #656 from jschoiRR/mold-main#2025

[Mold API] 복제기능 오류 수정(2개 이상 데이터디스크를 붙일 경우 에러), 볼륨 생성시 DeviceId 값 지정 추가

Author: jschoiRR

server/src/main/java/com/cloud/server/ManagementServerImpl.java

@@ -5937,7 +5937,7 @@ private LicenseCheckerResponse checkLicense(HostVO host) {
                         //     "License error for host " + host.getName(),
                         //     "License check failed: " + errorMessage
                         // );
-        } else {
+                    } else {
                         boolean isExpired = jsonNode.get("expiry_date").asBoolean();
                         boolean isIssued = jsonNode.get("issued_date").asBoolean();
                         String expiryDateStr = jsonNode.get("expired").asText();
@@ -5987,7 +5987,7 @@ private LicenseCheckerResponse checkLicense(HostVO host) {
                     connection.disconnect();
                 }
             }
-        return response;
+            return response;
         } catch (Exception e) {
             logger.error("Error checking license for host: " + host.getId(), e);
             throw new CloudRuntimeException("라이선스 체크 실패: " + e.getMessage());

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

@@ -9864,7 +9864,7 @@ public Optional<UserVm> cloneVirtualMachine(CloneVMCmd cmd) throws ResourceAlloc
                         _snapshotDao.update(snapVO.getId(), snapVO);
                     }
                     VolumeVO newVol = cloneVolumeFromSnapToDB(curVmAccount, true, zoneId, diskOfferingId, provisioningType, size, minIops, maxIops, parentRootVolume, rootVolumeName,
-                                                                        _uuidMgr.generateUuid(Volume.class, null), new HashMap<>(), Volume.Type.ROOT);
+                                                                        _uuidMgr.generateUuid(Volume.class, null), new HashMap<>(), Volume.Type.ROOT, 0L);
                     VolumeVO rootVolume = (VolumeVO) _volumeService.cloneVolumeFromSnapshot(newVol, snapVO.getId(), curVm.getId());
                     if (rootVolume == null) {
                         throw new CloudRuntimeException("Creation of root volume is not queried. The virtual machine cannot be cloned!");
@@ -9907,16 +9907,13 @@ public Optional<UserVm> cloneVirtualMachine(CloneVMCmd cmd) throws ResourceAlloc
                     VolumeVO newDataDiskVol = null;
                     try {
                         newDataDiskVol = cloneVolumeFromSnapToDB(curVmAccount, true, zoneId, diskOfferingId, provisioningType, size, minIops, maxIops, parentDataDiskVolume, dataVolumeName,
-                                                                            _uuidMgr.generateUuid(Volume.class, null), new HashMap<>(), Volume.Type.DATADISK);
+                                                                            _uuidMgr.generateUuid(Volume.class, null), new HashMap<>(), Volume.Type.DATADISK, parentDataDiskVolume.getDeviceId());
                         VolumeVO dataDiskVolume = (VolumeVO) _volumeService.cloneVolumeFromSnapshot(newDataDiskVol, snapVO.getId(), curVm.getId());
                         if (dataDiskVolume == null) {
                             throw new CloudRuntimeException("Creation of root volume is not queried. The virtual machine cannot be cloned!");
                         }
                         createdVolumes.add(dataDiskVolume);
-
-                        for (VolumeVO createdVol : createdVolumes) {
-                            _volumeService.attachVolumeToVM(cmd.getEntityId(), createdVol.getId(), createdVol.getDeviceId(), false);
-                        }
+                        _volumeService.attachVolumeToVM(cmd.getEntityId(), dataDiskVolume.getId(), dataDiskVolume.getDeviceId(), false);
                     } catch (CloudRuntimeException e){
                         logger.warn("data disk process failed during clone, clearing the temporary resources...");
                         for (VolumeVO dataDiskToClear : createdVolumes) {
@@ -10033,7 +10030,7 @@ public UserVm createCloneVM(CloneVMCmd cmd, Long rootVolumeId) throws Concurrent
     private VolumeVO cloneVolumeFromSnapToDB(final Account owner, final Boolean displayVolume, final Long zoneId, final Long diskOfferingId,
                                                     final Storage.ProvisioningType provisioningType, final Long size, final Long minIops, final Long maxIops,
                                                     final VolumeVO parentVolume, final String volumeName, final String uuid, final Map<String, String> details,
-                                                    Volume.Type volType) {
+                                                    Volume.Type volType, final Long deviceId) {
         return Transaction.execute((TransactionCallback<VolumeVO>) status -> {
             VolumeVO volume = new VolumeVO(volumeName, -1, -1, -1, -1, Long.valueOf(-1), null, null, provisioningType, 0, volType);
             volume.setPoolId(null);
@@ -10049,9 +10046,8 @@ private VolumeVO cloneVolumeFromSnapToDB(final Account owner, final Boolean disp
             volume.setInstanceId(null);
             volume.setUpdated(new Date());
             volume.setDisplayVolume(displayVolume);
-            if (volType == Volume.Type.ROOT) {
-                volume.setDeviceId(0L);
-            }
+            volume.setDeviceId(deviceId);
+
             if (parentVolume != null) {
                 volume.setTemplateId(parentVolume.getTemplateId());
                 volume.setFormat(parentVolume.getFormat());

ui/src/components/view/AnnotationsTab.vue

@@ -41,6 +41,7 @@
               </template>
               <template #actions>
                 <a-popconfirm
+                  placement="topLeft"
                   :title="this.$localStorage.get('LOCALE') == 'ko_KR' ?
                           (item.adminsonly ? $t('label.annotation.everyone') : $t('label.adminsonly')) + $t('label.make') + '?' :
                           $t('label.make') + ' ' + (item.adminsonly ? $t('label.annotation.everyone') : $t('label.adminsonly')) + '?'"
@@ -61,13 +62,14 @@
             </a-comment>
             <template #actions>
               <a-popconfirm
-                :title="$t('label.remove.annotation')"
+                placement="topRight"
+                :title="$t('message.remove.annotation')"
                 v-if="'removeAnnotation' in $store.getters.apis && isAdminOrAnnotationOwner(item)"
                 key="visibility"
                 @confirm="deleteNote(item)"
                 :okText="$t('label.yes')"
                 :cancelText="$t('label.no')" >
-                <delete-two-tone shape="circle" two-tone-color="#eb2f96" />
+                <a-button type="primary" shape="circle" danger><template #icon><delete-outlined /></template></a-button>
               </a-popconfirm>
             </template>
           </a-list-item>

ui/src/components/view/DetailsTab.vue

@@ -427,7 +427,6 @@ export default {
     fetchDetails () {
       let details = this.$route.meta.details
 
-      console.log('details :>> ', details)
       if (!details) {
         return
       }