[ECO-4567] Added cake script to format the code

- Formatted Main solution with all relevant C# files
- Fixed import issues in MsgPack serializer/deserializers

Author: sacOO7

.editorconfig

@@ -8,13 +8,19 @@ root = true
 indent_style = space
 indent_size = 4
 trim_trailing_whitespace = true
-insert_final_newline = false
+insert_final_newline = true
 
 # SA1200: Using directives should be placed correctly
 dotnet_diagnostic.SA1200.severity = none
 
+[*.cake]
+indent_style = space
+indent_size = 4
+trim_trailing_whitespace = true
+insert_final_newline = true
+
 [*.{xaml,xml,config,manifest}]
 indent_style = space
 indent_size = 2
 trim_trailing_whitespace = true
-insert_final_newline = false
+insert_final_newline = false

IMPLEMENTATION_PLAN.md

@@ -185,7 +185,7 @@ public AblyRequest(string path, HttpMethod method, Protocol protocol = Defaults.
 
 **Fix required:**
 ```csharp
-public AblyRequest(string path, HttpMethod method, Protocol protocol = Defaults.DefaultProtocol)
+public AblyRequest(string path, HttpMethod method, Protocol protocol = Defaults.Protocol)
 ```
 
 #### 3.2 Update AblyHttpClient.cs

cake-build/tasks/build.cake

@@ -190,3 +190,29 @@ Task("Build.Xamarin")
 Task("Update.AblyUnity")
     .Description("Update Ably DLLs inside unity project")
     .IsDependentOn("_Build_Ably_Unity_Dll");
+
+// Public task: Format code using dotnet-format
+Task("Format.Code")
+    .Description("Format code using dotnet-format")
+    .Does(() =>
+{
+    Information("Formatting code with dotnet-format...");
+    
+    // Using 'whitespace' mode for fast formatting without building the project
+    // This applies .editorconfig rules for whitespace, indentation, etc. without semantic analysis
+    // Much faster than default mode which requires compilation
+    var exitCode = StartProcess("dotnet", new ProcessSettings
+    {
+        Arguments = $"format {paths.MainSolution.FullPath} whitespace --no-restore"
+    });
+    
+    if (exitCode == 0)
+    {
+        Information("✓ Code formatted successfully");
+    }
+    else
+    {
+        throw new Exception($"dotnet format failed with exit code {exitCode}");
+    }
+});
+

examples/AndroidSample/AblyService.cs

@@ -18,14 +18,14 @@ public void Init()
             _ably = new AblyRealtime(new ClientOptions("lNj80Q.iGyVcQ:2QKX7FFASfX-7H9H")
             {
                 LogHandler = this,
-                LogLevel = LogLevel.Debug, 
+                LogLevel = LogLevel.Debug,
                 AutoConnect = false,
                 UseBinaryProtocol = false
             });
             _ably.Connection.On(change =>
             {
-                if(change.Current == ConnectionState.Connected)
-                    foreach(var channel in _ably.Channels)
+                if (change.Current == ConnectionState.Connected)
+                    foreach (var channel in _ably.Channels)
                         channel.Attach();
 
                 _connectionSubject.OnNext(change.Current.ToString());
@@ -48,7 +48,7 @@ public IObservable<Message> SubsrcibeToChannel(string channelName)
             _ably.Channels.Get(channelName).Subscribe(subject.OnNext);
             return subject;
         }
-             
+
         public void LogEvent(LogLevel level, string message)
         {
             Android.Util.Log.Debug("ably", $"[{level}] {message}");
@@ -66,6 +66,6 @@ public IDisposable Subscribe(IObserver<string> observer)
         }
     }
 
-    
+
 
 }

examples/AndroidSample/App.xaml.cs

@@ -34,7 +34,7 @@ public App(AblyService ably)
 
         protected override void OnStart()
         {
-            
+
             // Handle when your app starts
         }
 

format-code.cmd

@@ -0,0 +1 @@
+dotnet cake cake-build/build.cake -- --target=Format.Code

format-code.sh

@@ -0,0 +1 @@
+dotnet cake cake-build/build.cake -- --target=Format.Code

src/IO.Ably.Shared.MsgPack/CustomSerialisers/GeneratedSerializers/IO_Ably_Types_ProtocolMessageSerializer.cs

@@ -86,7 +86,6 @@ protected override void PackToCore(MsgPack.Packer packer, IO.Ably.Types.Protocol
                 objectTree.ChannelSerial.IsNotEmpty(),
                 objectTree.ConnectionDetails != null,
                 objectTree.ConnectionId.IsNotEmpty(),
-                objectTree.ConnectionSerial != null,
                 objectTree.Count != null,
                 objectTree.Error != null,
                 objectTree.Flags != null,
@@ -119,11 +118,6 @@ protected override void PackToCore(MsgPack.Packer packer, IO.Ably.Types.Protocol
                 this._serializer0.PackTo(packer, "connectionId");
                 this._serializer0.PackTo(packer, objectTree.ConnectionId);
             }
-            if (objectTree.ConnectionSerial != null)
-            {
-                this._serializer0.PackTo(packer, "connectionSerial");
-                this._serializer3.PackTo(packer, objectTree.ConnectionSerial);
-            }
             if (objectTree.Count != null)
             {
                 this._serializer0.PackTo(packer, "count");
@@ -409,15 +403,9 @@ protected override IO.Ably.Types.ProtocolMessage UnpackFromCore(MsgPack.Unpacker
                                             {
                                                 if ((key == "connectionSerial"))
                                                 {
-                                                    System.Nullable<long> nullable21 = default(System.Nullable<long>);
-                                                    nullable21 =
-                                                        MsgPack.Serialization.UnpackHelpers.UnpackNullableInt64Value(
-                                                            unpacker, typeof(IO.Ably.Types.ProtocolMessage),
-                                                            "System.Nullable`1[System.Int64] connectionSerial");
-                                                    if (nullable21.HasValue)
-                                                    {
-                                                        result.ConnectionSerial = nullable21;
-                                                    }
+                                                    // ConnectionSerial was removed in PR #1199
+                                                    // Skip this field if present in older messages
+                                                    unpacker.Skip();
                                                 }
                                                 else
                                                 {
@@ -569,7 +557,6 @@ protected override IO.Ably.Types.ProtocolMessage UnpackFromCore(MsgPack.Unpacker
                                                             }
                                                         }
                                                     }
-                                                    
                                                 }
                                             }
                                         }
@@ -595,4 +582,4 @@ private static T @__Conditional<T>(bool condition, T whenTrue, T whenFalse)
     }
 }
 #pragma warning restore SA1600 // Elements should be documented
-#pragma warning restore CS1591 // Missing XML comment for publicly visible type or member
+#pragma warning restore CS1591 // Missing XML comment for publicly visible type or member

src/IO.Ably.Shared/AblyAuth.cs

@@ -483,7 +483,7 @@ private static TokenRequest GetTokenRequest(object callbackResult)
         private async Task<AblyResponse> CallAuthUrl(AuthOptions mergedOptions, TokenParams @params)
         {
             var url = mergedOptions.AuthUrl;
-            var protocol = Options.UseBinaryProtocol == false ? Protocol.Json : Protocol.MsgPack;
+            var protocol = Options.UseBinaryProtocol ? Protocol.MsgPack : Defaults.Protocol;
             var authRequest = new AblyRequest(url.ToString(), mergedOptions.AuthMethod, protocol);
 
             if (mergedOptions.AuthMethod == HttpMethod.Get)

src/IO.Ably.Shared/AblyRest.cs

@@ -115,7 +115,7 @@ public LocalDevice Device
             internal set => _device = value; // The setting is only for testing purposes
         }
 
-        internal Protocol Protocol => Options.UseBinaryProtocol == false ? Protocol.Json : Defaults.Protocol;
+        internal Protocol Protocol => Options.UseBinaryProtocol ? Protocol.MsgPack : Defaults.Protocol;
 
         internal ClientOptions Options { get; }