Fixed #236

The tool will not log an error in the error.log if a directory name in a
file path endswith space.

Author: chinyeungli

about_code_tool/genabout.py

@@ -481,7 +481,7 @@ def process_dje_licenses(self, dje_license_list, dje_license_dict, output_path):
 
     def pre_generation(self, gen_location, input_list, action_num):
         """
-        Perfom some pre-generation.
+        Perform some pre-generation.
         TODO: document me
         """
         output_list = []
@@ -500,6 +500,18 @@ def pre_generation(self, gen_location, input_list, action_num):
                     file_location = dirname(file_location)
                     file_location = join(file_location, basename(file_location))
                 file_location += '.ABOUT'
+            # The following code is to check if there is any directory ends with spaces
+            split_path = file_location.split('/')
+            dir_endswith_space = False
+            for segment in split_path:
+                if segment.endswith(' '):
+                    msg = 'File path contains directory name ends with spaces which is not allowed. Generation skipped.'
+                    self.errors.append(Error(VALUE, 'about_file_path',
+                                             file_location, msg))
+                    dir_endswith_space = True
+                    break
+            if dir_endswith_space:
+                continue
 
             about_file_location = join(gen_location, file_location)
             about_file_dir = dirname(about_file_location)

about_code_tool/tests/test_genabout.py

@@ -514,6 +514,21 @@ def test_pre_generation_about_exists_action_3(self):
         self.assertFalse(gen.warnings, 'No warnings should be returned.')
         self.assertFalse(gen.errors, 'No errors should be returned.')
 
+    def test_pre_generation_dir_endswith_space(self):
+        gen = genabout.GenAbout()
+        test_fields = [{'about_file': '/abc /about.py.ABOUT',
+                        'version': '0.8.2',
+                        'about_resource': '.',
+                        'name': '',
+                        'test': 'test sample'}]
+
+        result = gen.pre_generation(GEN_LOCATION,
+                                    test_fields,
+                                    action_num=0)
+
+        self.assertTrue(len(gen.errors) == 1, 'Should return 1 error.')
+        self.assertTrue(gen.errors, 'It should prompt error because directory ends with sapce')
+
     def test_format_output(self):
         gen = genabout.GenAbout()
         test_fields = [