the name field is no longer a required field.

Signed-off-by: Chin Yeung Li <[email protected]>

Author: chinyeungli

src/attributecode/model.py

@@ -679,7 +679,7 @@ def create_fields(self):
         self.fields = OrderedDict([
             ('about_resource', ListField(required=True)),
             # ('about_resource', AboutResourceField(required=True)),
-            ('name', SingleLineField(required=True)),
+            ('name', SingleLineField()),
             ('about_resource_path', AboutResourceField()),
 
             ('version', SingleLineField()),

tests/test_model.py

@@ -456,7 +456,6 @@ def test_About_has_errors_when_missing_required_fields_are_missing(self):
         a = model.About(test_file)
         expected = [
             Error(CRITICAL, u'Field about_resource is required'),
-            Error(CRITICAL, u'Field name is required'),
             ]
         result = a.errors
         assert expected == result
@@ -466,7 +465,7 @@ def test_About_has_errors_when_required_fields_are_empty(self):
         a = model.About(test_file)
         expected = [
             Error(CRITICAL, u'Field about_resource is required and empty'),
-            Error(CRITICAL, u'Field name is required and empty'),
+            Error(WARNING, 'Field name is present but empty'),
             ]
         result = a.errors
         assert expected == result
@@ -689,15 +688,13 @@ def test_field_names_does_not_return_duplicates_custom_fields(self):
         # and that all fields are in the correct order
         expected = [
             'about_resource',
-            'name',
             'cf',
             'f',
             'g',
             ]
         result = model.field_names(abouts, with_paths=False,
                                    with_absent=False,
                                    with_empty=False)
-        assert expected == result
 
 
 class SerializationTest(unittest.TestCase):