#378 - Add support for special character

 - Add support for the following chars: "(", ")", "~", "[", "]", "{",
"}"

Signed-off-by: Chin Yeung Li <[email protected]>

Author: chinyeungli

SPECIFICATION.rst

@@ -72,7 +72,7 @@ A file name can contain only these US-ASCII characters:
 
 - digits from 0 to 9
 - uppercase and lowercase letters from A to Z
-- the "_" underscore, "-" dash, "+" plus and "." period signs.
+- the following symbols: "_", "-", "+", ".", "(", ")", "~", "[", "]", "{", "}"
 
 - The case of a file name is not significant. On case-sensitive file systems
   (such as on Linux), a tool must report an error if two ABOUT files stored in

docs/CHANGELOG.rst

@@ -1,10 +1,9 @@
-2018-XX-XX
+2019-XX-XX
 
     Release 3.4.0.pre1
 
-    * Support filenames/path with spaces #310
+    * Support filenames/path with special characters #310 #378 #392
     * Update ABOUT file format to match the specification
-    * Support filename/path with a "+" plus sign #392
 
 2018-11-15
 

src/attributecode/util.py

@@ -67,7 +67,7 @@ def to_posix(path):
 UNC_PREFIX_POSIX = to_posix(UNC_PREFIX)
 UNC_PREFIXES = (UNC_PREFIX_POSIX, UNC_PREFIX,)
 
-valid_file_chars = string.digits + string.ascii_letters + '_-.+' + ' '
+valid_file_chars = string.digits + string.ascii_letters + '_-.+()~[]{}|' + ' '
 
 
 def invalid_chars(path):

tests/test_util.py

@@ -149,9 +149,9 @@ def test_invalid_chars_with_invalid_in_name_and_dir(self):
         assert expected == result
 
     def test_invalid_chars_in_file_name(self):
-        name = '%657!1351()275612$_$asafg:'
+        name = '%657!1351()275612$_$asafg:~|[]{}+-.'
         result = util.invalid_chars(name)
-        expected = ['%', '!', '(', ')', '$', '$', ':']
+        expected = ['%', '!', '$', '$', ':']
         assert expected == result
 
     def test_invalid_chars_with_space_is_valid(self):