Fixed #403 - Correct invalid msg for boolean fields

 * Add more tests.

Author: chinyeungli

src/attributecode/model.py

@@ -795,21 +795,8 @@ def __eq__(self, other):
     def all_fields(self):
         """
         Return the list of all Field objects.
-        If with_absent, include absent (not present) fields.
-        If with_empty, include empty fields.
         """
-        all_fields = []
-
-        for field in list(self.fields.values()) + list(self.custom_fields.values()):
-            if field.required:
-                all_fields.append(field)
-            else:
-                if field.present:
-                    if field.value:
-                        all_fields.append(field)
-                    elif field.name in boolean_fields and not field.value == None:
-                        all_fields.append(field)
-        return all_fields
+        return list(self.fields.values()) + list(self.custom_fields.values())
 
     def as_dict(self):
         """

tests/test_model.py

@@ -578,6 +578,27 @@ def test_About_invalid_boolean_value(self):
         expected_msg = "Field modified: Invalid flag value: 'blah'"
         assert expected_msg in a.errors[0].message
 
+    def test_About_boolean_value(self):
+        test_file = get_test_loc('test_model/parse/boolean_data.about')
+        a = model.About(test_file)
+        expected_msg = "Field track_changes is present but empty."
+        assert expected_msg in a.errors[0].message
+        # Context of the test file
+        """
+        about_resource: .
+        name: boolean_data
+        attribute: False
+        modified: true
+        internal_use_only: no
+        redistribute: yes
+        track_changes:
+        """
+        assert a.attribute.value is False
+        assert a.modified.value is True
+        assert a.internal_use_only.value is False
+        assert a.redistribute.value is True
+        assert a.track_changes.value is None
+
     def test_About_contains_about_file_path(self):
         test_file = get_test_loc('test_model/serialize/about.ABOUT')
         # TODO: I am not sure this override of the about_file_path makes sense

tests/testdata/test_model/parse/boolean_data.about

@@ -0,0 +1,7 @@
+about_resource: .
+name: boolean_data
+attribute: False
+modified: true
+internal_use_only: no
+redistribute: yes
+track_changes: