#492 - Enhance performance

 * Remove extra "deduplicate" function call. The `unique` is called in
the `report_errors`, so we do not need to call the `unique` multiple
time.

Signed-off-by: Chin Yeung Li <[email protected]>

Author: chinyeungli

src/attributecode/cmd.py

@@ -188,7 +188,6 @@ def inventory(location, output, format, quiet, verbose):  # NOQA
     errors, abouts = collect_inventory(location)
     write_output(abouts=abouts, location=output, format=format)
 
-    errors = unique(errors)
     errors_count = report_errors(errors, quiet, verbose, log_file_loc=output + '-error.log')
     if not quiet:
         msg = 'Inventory collected in {output}.'.format(**locals())
@@ -270,7 +269,6 @@ def gen(location, output, android, fetch_license, fetch_license_djc, reference,
         fetch_license_djc=fetch_license_djc,
     )
 
-    errors = unique(errors)
     errors_count = report_errors(errors, quiet, verbose, log_file_loc=output + '-error.log')
     if not quiet:
         abouts_count = len(abouts)
@@ -355,7 +353,6 @@ def gen_license(location, output, djc, scancode, verbose):
     if write_errors:
         errors.extend(write_errors)
 
-    errors = unique(errors)
     severe_errors_count = report_errors(errors, quiet=False, verbose=verbose, log_file_loc=log_file_loc)
     sys.exit(severe_errors_count)
 
@@ -499,12 +496,11 @@ def attrib(input, output, api_url, api_key, scancode, min_license_score, referen
 
     if not abouts:
         if errors:
-            errors = unique(errors)
             errors_count = report_errors(errors, quiet, verbose, log_file_loc=output + '-error.log')
         else:
             msg = 'No ABOUT file or reference is found from the input. Attribution generation halted.'
             click.echo(msg)
-        sys.exit(1)
+        sys.exit(errors_count)
 
     if not is_about_input:
         # Check if both api_url and api_key present
@@ -547,7 +543,6 @@ def attrib(input, output, api_url, api_key, scancode, min_license_score, referen
         )
         errors.extend(attrib_errors)
 
-    errors = unique(errors)
     errors_count = report_errors(errors, quiet, verbose, log_file_loc=output + '-error.log')
 
     if not quiet:
@@ -714,7 +709,6 @@ def check(location, djc, log, verbose):
     for e in errs:
         errors.append(e)
 
-    errors = unique(errors)
     severe_errors_count = report_errors(errors, quiet=False, verbose=verbose, log_file_loc=log)
     sys.exit(severe_errors_count)
 
@@ -796,7 +790,6 @@ def transform(location, output, configuration, quiet, verbose):  # NOQA
         print_version()
         click.echo('Transforming...')
 
-    errors = unique(errors)
     errors_count = report_errors(errors, quiet, verbose, log_file_loc=output + '-error.log')
     if not quiet and not errors:
         msg = 'Transformed file is written to {output}.'.format(**locals())
@@ -817,7 +810,6 @@ def report_errors(errors, quiet, verbose, log_file_loc=None):
     file.
     Return True if there were severe error reported.
     """
-    errors = unique(errors)
     messages, severe_errors_count = get_error_messages(errors, quiet, verbose)
     for msg in messages:
         click.echo(msg)