Fixed no error.log if no error detected #294

Signed-off-by: Chin Yeung Li <[email protected]>

Author: chinyeungli

src/attributecode/cmd.py

@@ -406,9 +406,8 @@ def log_errors(errors, quiet, show_all, base_dir=False):
 
     msg_format = '%(sever)s: %(message)s'
 
-    # FIXME: do not create log file if there are NO errors
-    # Create error.log
-    if base_dir:
+    # Create error.log if problematic_error detected
+    if base_dir and have_problematic_error(errors):
         bdir = to_posix(base_dir)
         LOG_FILENAME = 'error.log'
         log_path = join(bdir, LOG_FILENAME)
@@ -426,8 +425,16 @@ def log_errors(errors, quiet, show_all, base_dir=False):
             elif sever in problematic_errors:
                 print(msg_format % locals())
         if base_dir:
+            # The logger will only log error if severity >= 30
             file_logger.log(severity, msg_format % locals())
 
 
+def have_problematic_error(errors):
+    for severity, message in errors:
+        sever = severities[severity]
+        if sever in problematic_errors:
+            return True
+    return False
+
 if __name__ == '__main__':
     cli()

tests/test_cmd.py

@@ -85,4 +85,20 @@ def test_log_errors_with_quiet(capsys):
     cmd.log_errors(errors, quiet, show_all, base_dir='')
     out, err = capsys.readouterr()
     assert '' == out
-    assert '' == err
+    assert '' == err
+
+
+def test_have_problematic_error():
+    have_problematic_errors = [Error(CRITICAL, 'msg1'),
+                               Error(ERROR, 'msg2'),
+                               Error(INFO, 'msg3'),
+                               Error(WARNING, 'msg4'),
+                               Error(DEBUG, 'msg4'),
+                               Error(NOTSET, 'msg4'),
+                               ]
+    no_problematic_errors = [Error(INFO, 'msg3'),
+                             Error(DEBUG, 'msg4'),
+                             Error(NOTSET, 'msg4'),
+                             ]
+    assert cmd.have_problematic_error(have_problematic_errors)
+    assert cmd.have_problematic_error(no_problematic_errors) == False