Fixed #200 Do not treat file resource not found as problematic errors

 * Lower the severity level for about_resource not found error to INFO
level. As a result, this error will only be shown if user set the
`--verbose`

Signed-off-by: Chin Yeung Li <[email protected]>

Author: chinyeungli

src/attributecode/cmd.py

@@ -35,7 +35,7 @@
 from attributecode import model
 from attributecode import severities
 from attributecode.util import extract_zip
-from attributecode.util import ignore_about_resource_path_not_exist_error
+from attributecode.util import update_severity_level_about_resource_path_not_exist_error
 from attributecode.util import to_posix
 
 
@@ -161,7 +161,7 @@ def inventory(location, output, mapping, mapping_file, quiet, format, verbose):
     for err in write_errors:
         errors.append(err)
 
-    finalized_errors = ignore_about_resource_path_not_exist_error(errors)
+    finalized_errors = update_severity_level_about_resource_path_not_exist_error(errors)
 
     log_errors(finalized_errors, quiet, verbose, os.path.dirname(output))
     sys.exit(0)
@@ -239,7 +239,7 @@ def gen(location, output, mapping, mapping_file, license_notice_text_location, f
 
     about_count = len(abouts)
     error_count = 0
-    finalized_errors = ignore_about_resource_path_not_exist_error(errors)
+    finalized_errors = update_severity_level_about_resource_path_not_exist_error(errors)
 
     for e in finalized_errors:
         # Only count as warning/error if CRITICAL, ERROR and WARNING
@@ -325,7 +325,7 @@ def attrib(location, output, template, mapping, mapping_file, inventory, quiet,
     for no_match_error in no_match_errors:
         inv_errors.append(no_match_error)
 
-    finalized_errors = ignore_about_resource_path_not_exist_error(inv_errors)
+    finalized_errors = update_severity_level_about_resource_path_not_exist_error(inv_errors)
 
     log_errors(finalized_errors, quiet, verbose, os.path.dirname(output))
     click.echo('Finished.')

src/attributecode/util.py

@@ -46,7 +46,7 @@
     # Python 3
     import http.client as httplib
 
-from attributecode import CRITICAL
+from attributecode import CRITICAL, INFO
 from attributecode import Error
 
 
@@ -534,12 +534,13 @@ def copy_license_notice_files(fields, base_dir, license_notice_text_location, af
                 print('Cannot copy file at %(from_lic_path)r.' % locals())
 
 
-def ignore_about_resource_path_not_exist_error(errors):
+def update_severity_level_about_resource_path_not_exist_error(errors):
     ignore_resource_path_check_message = u'Field about_resource_path:'
     updated_errors = []
     for err in errors:
         if ignore_resource_path_check_message in err.message:
-            continue
+            updated_errors.append(Error(INFO, err.message))
+            #continue
         else:
             updated_errors.append(err)
     return updated_errors

tests/test_util.py

@@ -29,7 +29,7 @@
 from testing_utils import on_windows
 
 from attributecode import CRITICAL
-from attributecode import ERROR
+from attributecode import ERROR, INFO
 from attributecode import Error
 from attributecode import util
 
@@ -440,8 +440,7 @@ def test_apply_mapping(self):
                          ])]
         assert util.apply_mapping(input) == expected
 
-    def test_ignore_about_resource_path_not_exist_error(self):
-        input_err = [Error(ERROR, 'Field about_resource_path: test.tar.gz does not exist'),
-                     Error(ERROR, 'Field about_resource_path: test.tar.gz does not exist')]
-        expected_err = []
-        assert util.ignore_about_resource_path_not_exist_error(input_err) == expected_err
+    def test_update_severity_level_about_resource_path_not_exist_error(self):
+        input_err = [Error(ERROR, 'Field about_resource_path: test.tar.gz does not exist')]
+        expected_err = [Error(INFO, 'Field about_resource_path: test.tar.gz does not exist')]
+        assert util.update_severity_level_about_resource_path_not_exist_error(input_err) == expected_err