Skip to content

Commit c2689a3

Browse files
committed
Add TODO / FIXME comment as reminders
Signed-off-by: Philippe Ombredanne <[email protected]>
1 parent a6d8aec commit c2689a3

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/attributecode/model.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1039,6 +1039,8 @@ def load(self, location, use_mapping=False, mapping_file=None):
10391039
self.errors = errors
10401040
return errors
10411041

1042+
# FIXME: should be a from_dict class factory instead
1043+
# FIXME: an About object should not know about mappings
10421044
def load_dict(self, fields_dict, base_dir, running_inventory=False,
10431045
use_mapping=False, mapping_file=None,
10441046
license_notice_text_location=None, with_empty=True):
@@ -1054,6 +1056,7 @@ def load_dict(self, fields_dict, base_dir, running_inventory=False,
10541056
fields = [(n, v) for n, v in fields_dict.items() if v]
10551057
for key, value in fields:
10561058
if key == u'licenses':
1059+
# FIXME: use a license object instead
10571060
lic_key, lic_name, lic_file, lic_url = ungroup_licenses(value)
10581061
if lic_key:
10591062
fields.append(('license_key', lic_key))

0 commit comments

Comments
 (0)