Skip to content

Commit b43507f

Browse files
Fix module defination for binary_inspector
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
1 parent c8be8aa commit b43507f

File tree

11 files changed

+78
-291
lines changed

11 files changed

+78
-291
lines changed

.github/workflows/docs-ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,6 @@ jobs:
2929
- name: Check documentation for style errors
3030
run: make doc8
3131

32+
- name: Check code for style errors
33+
run: make check
3234

CHANGELOG.rst

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,11 @@ Initial release with support for:
1111
* Get parsed list of demangled and cleaned symbols from a macho binary
1212
* scancode-toolkit plugins for collecting symbols from macho and winpe binaries
1313
with the CLI option --winpe-symbol --macho-symbol
14+
15+
v0.1.1
16+
------
17+
18+
Bugfix release as the intial release had empty wheels:
19+
20+
* Fix binary-inspector wheels to have the necessary modules.
21+
* Update to latest skeleton

requirements-dev.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
scancode-toolkit==32.3.3

setup.cfg

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ license_files =
3131
README.rst
3232

3333
[options]
34-
python_requires = >=3.9
35-
3634
package_dir =
3735
=src
3836
packages = find:
@@ -63,6 +61,7 @@ where = src
6361

6462
[options.extras_require]
6563
dev =
64+
scancode-toolkit
6665
pytest >= 7.0.1
6766
pytest-xdist >= 2
6867
aboutcode-toolkit >= 7.0.2

src/binary_inspector/binary.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -73,18 +73,15 @@ def might_have_macho_symbols(string_with_symbols):
7373
if len(string_with_symbols) < 2:
7474
return False
7575

76-
if any(
77-
ignore_char in string_with_symbols
78-
for ignore_char in ignore_chars
79-
):
76+
if any(ignore_char in string_with_symbols for ignore_char in ignore_chars):
8077
return False
8178

8279
return True
8380

8481

8582
def remove_standard_symbols(macho_symbols, standard_symbols=STANDARD_SYMBOLS_MACHO):
8683
"""
87-
Remove standard symbols usually found in macho binaries. Given a list of machot
84+
Remove standard symbols usually found in macho binaries. Given a list of machot
8885
symbol strings, return a list of symbol strings which are most likely non-standard.
8986
"""
9087
return [symbol for symbol in macho_symbols if symbol not in standard_symbols]
@@ -160,8 +157,7 @@ def extract_strings_with_symbols(
160157
"""
161158
strings_with_symbols = []
162159
for symbol_data in symbols_data:
163-
164-
#TODO: get and match using fully qualified "name"
160+
# TODO: get and match using fully qualified "name"
165161
symbol_name = symbol_data.get("short_name")
166162
strings_with_symbols.append(symbol_name)
167163

0 commit comments

Comments
 (0)