Stream large files when computing hash #72 #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Omkar Phansopkar <[email protected]>
Added docs server script, dark mode & copybutton for docs, tracking chmod in git
Reference: aboutcode-org/skeleton#84 Signed-off-by: John M. Horan <[email protected]>
Reference: aboutcode-org/skeleton#84 Signed-off-by: John M. Horan <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Update CSS to widen page and handle mobile #84
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Update CI runners and python version
Replace macos-11 runners with macos-14 runners. Reference: https://github.com/actions/runner-images?tab=readme-ov-file#available-images Reference: aboutcode-org/skeleton#89 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Replace deprecated macos CI runners
Signed-off-by: Chin Yeung Li <[email protected]>
Scanning a large file may exhaust memory and file because commoncode.hash loads the whole file in memory. With this commit, the files are loaded in chunks so we do not run out of memory on very large files, such as VM images. Reference: #72 Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
pombredanne
commented
Dec 6, 2024
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
72-large-file-hash
branch
from
cf1fa3b to
b061812
Compare
AyanSinhaMahapatra
approved these changes
Dec 6, 2024
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
LGTM!
Thanks @pombredanne
Merging with a few docstring and other minor updates
AyanSinhaMahapatra
force-pushed
the
72-large-file-hash
branch
3 times, most recently
from
299ede9 to
b467d2e
Compare
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra
force-pushed
the
72-large-file-hash
branch
from
b467d2e to
359f72b
Compare
Member
Author
|
Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix for #72
It streams large files in chunks when computing checksums to avoid exhausting memory