Fix click compatibility issues #89
Merged
+40
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Theodore Aptekarev <[email protected]> Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
piiq
reviewed
Jun 11, 2025
| # TODO Remove when dropping support for Python 3.9 or Click 8.1. | ||
| @property | ||
| def is_hidden(self) -> bool: | ||
| return self.hidden |
Contributor
There was a problem hiding this comment.
Won't this be failing on click <8.2 because self.hidden does not exist?
Contributor
There was a problem hiding this comment.
Ah, I see now that you've implemented a version cap for python 3.9
piiq
approved these changes
Jun 11, 2025
Contributor
piiq
left a comment
piiq
left a comment
There was a problem hiding this comment.
Thanks for taking this over
🚀
Member
Author
|
Thanks++ @piiq, all good, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks++ to @piiq for:
which this is based on.
See for more info:
python3.9even though this is not EOL pallets/click#2975