Skip to content

Commit 74976c1

Browse files
authored
Replace the hardcoded /var/www/html by named volume #157 (#322)
Signed-off-by: tdruez <[email protected]>
1 parent 5d1f75c commit 74976c1

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

CHANGELOG.rst

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,17 @@ Release notes
77
https://github.com/aboutcode-org/dejacode/pull/315
88
https://github.com/aboutcode-org/dejacode/pull/312
99

10+
- Replace the hardcoded ``/var/www/html`` by a ``webroot`` named volume in
11+
``docker-compose.yml``.
12+
In the Docker compose ``nginx`` service, the hardcoded ``/var/www/html`` was declared
13+
as a volume which would cause issues when the ``/var/`` was not available on the
14+
local machine.
15+
The Docker volume directory ``/var/lib/docker/volumes/dejacode_webroot/_data`` can
16+
now be used in place of ``/var/www/html`` as the ``certbot --webroot-path`` for
17+
HTTP certificates management.
18+
https://github.com/aboutcode-org/dejacode/issues/157
19+
https://github.com/aboutcode-org/dejacode/pull/322
20+
1021
- Add REST API "actions" in package endpoint to track the scan status and fetch results:
1122
* `/packages/{uuid}/scan_info/` Scan information including the current status.
1223
* `/packages/{uuid}/scan_results/` Scan results.

docker-compose.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,8 @@ services:
8686
- "${NGINX_PUBLISHED_HTTPS_PORT:-443}:443"
8787
volumes:
8888
- ./etc/nginx/conf.d/:/etc/nginx/conf.d/
89-
- /var/www/html:/var/www/html
9089
- static:/var/dejacode/static/
90+
- webroot:/var/www/html/
9191
depends_on:
9292
- web
9393
restart: always
@@ -107,3 +107,4 @@ volumes:
107107
clamav_data:
108108
static:
109109
media:
110+
webroot:

0 commit comments

Comments
 (0)