Address review comments

Signed-off-by: Tushar Goel <[email protected]>

Author: TG1999

src/fetchcode/cpan.py

@@ -35,23 +35,24 @@ def get_download_url(purl: str):
         if not p.name or not p.version:
             return None
 
-        try:
-            parsed_name = urllib.parse.quote(p.name)
-            parsed_version = urllib.parse.quote(p.version)
-            api = f"https://fastapi.metacpan.org/v1/release/{parsed_name}/{parsed_version}"
+        parsed_name = urllib.parse.quote(p.name)
+        parsed_version = urllib.parse.quote(p.version)
+        api = f"https://fastapi.metacpan.org/v1/release/{parsed_name}/{parsed_version}"
+        if _http_exists(api):
+            # Fetch release data from MetaCPAN API
+            # Example: https://fastapi.metacpan.org/v1/release/Some-Module/1.2.3
             data = fetch_json_response(url=api)
             url = data.get("download_url") or data.get("archive")
             if url and _http_exists(url):
                 return url
-        except Exception:
-            pass
 
         author = p.namespace
-        if author:
-            auth = author.upper()
-            a = auth[0]
-            ab = auth[:2] if len(auth) >= 2 else auth
-            for ext in (".tar.gz", ".zip"):
-                url = f"https://cpan.metacpan.org/authors/id/{a}/{ab}/{auth}/{p.name}-{p.version}{ext}"
-                if _http_exists(url):
-                    return url
+        if not author:
+            return
+        auth = author.upper()
+        a = auth[0]
+        ab = auth[:2] if len(auth) >= 2 else auth
+        for ext in (".tar.gz", ".zip"):
+            url = f"https://cpan.metacpan.org/authors/id/{a}/{ab}/{auth}/{p.name}-{p.version}{ext}"
+            if _http_exists(url):
+                return url

tests/test_cpan.py

@@ -39,7 +39,7 @@ def test_success_from_metacpan_api(valid_purl):
         result = get_download_url(valid_purl)
         assert result == expected_url
         mock_fetch.assert_called_once()
-        mock_exists.assert_called_once_with(expected_url)
+        assert mock_exists.call_count == 2
 
 
 def test_fallback_to_author_path(valid_purl):
@@ -68,7 +68,7 @@ def test_author_zip_fallback(valid_purl):
 
         result = get_download_url(valid_purl)
         assert result == zip_url
-        assert mock_exists.call_count == 2
+        assert mock_exists.call_count == 3
         assert tar_url in [call[0][0] for call in mock_exists.call_args_list]
 
 
@@ -79,7 +79,7 @@ def test_neither_api_nor_fallback_works(valid_purl):
 
         result = get_download_url(valid_purl)
         assert result is None
-        assert mock_exists.call_count == 2
+        assert mock_exists.call_count == 3
 
 
 def test_missing_name_or_version():