Skip to content

Commit 1a72520

Browse files
authored
Move write_packageurls_to_file and write_data_to_file to minecode_pipeline.pipes #660 (#681)
Signed-off-by: Jono Yang <[email protected]>
1 parent 8e79402 commit 1a72520

File tree

2 files changed

+23
-18
lines changed

2 files changed

+23
-18
lines changed

minecode_pipeline/pipes/__init__.py

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,23 @@
66
# See https://github.com/aboutcode-org/purldb for support or download.
77
# See https://aboutcode.org for more information about nexB OSS projects.
88
#
9+
10+
import os
11+
import saneyaml
12+
13+
from pathlib import Path
14+
15+
from aboutcode.hashid import PURLS_FILENAME
16+
17+
18+
def write_packageurls_to_file(repo, base_dir, packageurls):
19+
purl_file_rel_path = os.path.join(base_dir, PURLS_FILENAME)
20+
purl_file_full_path = Path(repo.working_dir) / purl_file_rel_path
21+
write_data_to_file(path=purl_file_full_path, data=packageurls)
22+
return purl_file_rel_path
23+
24+
25+
def write_data_to_file(path, data):
26+
path.parent.mkdir(parents=True, exist_ok=True)
27+
with open(path, encoding="utf-8", mode="w") as f:
28+
f.write(saneyaml.dump(data))

minecode_pipeline/pipes/pypi.py

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,10 @@
2323
import os
2424
import json
2525
import requests
26-
import saneyaml
2726

28-
from pathlib import Path
2927
from datetime import datetime
3028

29+
from minecode_pipeline import pipes
3130
from minecode_pipeline.miners.pypi import get_pypi_packages
3231
from minecode_pipeline.miners.pypi import load_pypi_packages
3332
from minecode_pipeline.miners.pypi import get_pypi_packageurls
@@ -38,7 +37,6 @@
3837
from packageurl import PackageURL
3938

4039
from aboutcode.hashid import get_package_base_dir
41-
from aboutcode.hashid import PURLS_FILENAME
4240

4341

4442
from scanpipe.pipes.federatedcode import clone_repository
@@ -89,23 +87,10 @@ def update_last_serial_mined(
8987
}
9088
cloned_repo = clone_repository(repo_url=settings_repo)
9189
settings_path = os.path.join(cloned_repo.working_dir, settings_path)
92-
write_data_to_file(path=settings_path, data=settings_data)
90+
pipes.write_data_to_file(path=settings_path, data=settings_data)
9391
commit_and_push_changes(repo=cloned_repo, file_to_commit=settings_path)
9492

9593

96-
def write_packageurls_to_file(repo, base_dir, packageurls):
97-
purl_file_rel_path = os.path.join(base_dir, PURLS_FILENAME)
98-
purl_file_full_path = Path(repo.working_dir) / purl_file_rel_path
99-
write_data_to_file(path=purl_file_full_path, data=packageurls)
100-
return purl_file_rel_path
101-
102-
103-
def write_data_to_file(path, data):
104-
path.parent.mkdir(parents=True, exist_ok=True)
105-
with open(path, encoding="utf-8", mode="w") as f:
106-
f.write(saneyaml.dump(data))
107-
108-
10994
def mine_and_publish_pypi_packageurls(packages, use_last_serial=False, logger=None):
11095
if use_last_serial:
11196
last_serial_fetched = fetch_last_serial_mined()
@@ -155,7 +140,7 @@ def mine_and_publish_pypi_packageurls(packages, use_last_serial=False, logger=No
155140
logger(f"packageURLs: {purls_string}")
156141

157142
# write packageURLs to file
158-
purl_file = write_packageurls_to_file(
143+
purl_file = pipes.write_packageurls_to_file(
159144
repo=cloned_repo,
160145
base_dir=package_base_dir,
161146
packageurls=packageurls,

0 commit comments

Comments
 (0)