Sort license validation messages

This helps to have a stable output when testing

Signed-off-by: Philippe Ombredanne <[email protected]>

Author: pombredanne

src/licensedcode/models.py

@@ -642,7 +642,7 @@ def validate(licenses, verbose=False, no_dupe_urls=False):
                 continue
             errors['GLOBAL'].append(
                 f'Duplicate short name (ignoring case): {short_name} in licenses: ' +
-                ', '.join(l.key for l in licenses)
+                ', '.join(sorted(l.key for l in licenses))
             )
 
         # global name dedupe
@@ -651,7 +651,7 @@ def validate(licenses, verbose=False, no_dupe_urls=False):
                 continue
             errors['GLOBAL'].append(
                 f'Duplicate name (ignoring case): {name} in licenses: ' +
-                ', '.join(l.key for l in licenses)
+                ', '.join(sorted(l.key for l in licenses))
             )
 
         errors = {k: v for k, v in errors.items() if v}

tests/licensedcode/test_models.py

@@ -100,8 +100,8 @@ def test_validate_license_library_can_return_errors(self):
         expected_errors = {
             'GLOBAL': [
                 'Duplicate texts in multiple licenses: apache-2.0: TEXT, bsd-ack-carrot2: TEXT',
-                'Duplicate short name (ignoring case): gpl 1.0 in licenses: gpl-1.0-plus, gpl-1.0',
-                'Duplicate name (ignoring case): gnu general public license 1.0 in licenses: gpl-1.0-plus, gpl-1.0'],
+                'Duplicate short name (ignoring case): gpl 1.0 in licenses: gpl-1.0, gpl-1.0-plus',
+                'Duplicate name (ignoring case): gnu general public license 1.0 in licenses: gpl-1.0, gpl-1.0-plus'],
             'bsd-ack-carrot2': [
                 'No short name',
                 'No name',