Set run_order field on plugins #3377

Signed-off-by: Jono Yang <[email protected]>

Author: JonoYang

src/cluecode/plugin_copyright.py

@@ -28,6 +28,7 @@ class CopyrightScanner(ScanPlugin):
         ('authors', attr.ib(default=attr.Factory(list))),
     ])
 
+    run_order = 6
     sort_order = 6
 
     options = [

src/cluecode/plugin_email.py

@@ -25,6 +25,7 @@ class EmailScanner(ScanPlugin):
     """
     resource_attributes = dict(emails=attr.ib(default=attr.Factory(list)))
 
+    run_order = 7
     sort_order = 7
 
     options = [

src/cluecode/plugin_filter_clues.py

@@ -41,6 +41,7 @@ class RedundantCluesFilter(PostScanPlugin):
     Filter redundant clues (copyrights, authors, emails, and urls) that are
     already contained in a matched license text.
     """
+    run_order = 1
     sort_order = 1
 
     options = [

src/cluecode/plugin_url.py

@@ -26,6 +26,7 @@ class UrlScanner(ScanPlugin):
 
     resource_attributes = dict(urls=attr.ib(default=attr.Factory(list)))
 
+    run_order = 8
     sort_order = 8
 
     options = [

src/licensedcode/licenses_reference.py

@@ -48,6 +48,7 @@ class LicenseReference(PostScanPlugin):
     )
 
     # TODO: send to the tail of the scan, after files
+    run_order = 1000
     sort_order = 1000
 
     options = [

src/licensedcode/plugin_license.py

@@ -71,6 +71,7 @@ class LicenseScanner(ScanPlugin):
         license_detections=attr.ib(default=attr.Factory(list)),
     )
 
+    run_order = 4
     sort_order = 4
 
     options = [

src/licensedcode/plugin_license_policy.py

@@ -51,6 +51,7 @@ class LicensePolicy(PostScanPlugin):
 
     resource_attributes = dict(license_policy=attr.ib(default=attr.Factory(list)))
 
+    run_order = 9
     sort_order = 9
 
     options = [
@@ -100,8 +101,8 @@ def process_codebase(self, codebase, license_policy, **kwargs):
                     if key == policy.get('license_key'):
                         # Apply the policy to the Resource
                         license_policies.append(policy)
-            
-            resource.license_policy = sorted(license_policies, key=lambda d: d['license_key']) 
+
+            resource.license_policy = sorted(license_policies, key=lambda d: d['license_key'])
             codebase.save_resource(resource)
 
 

src/packagedcode/plugin_package.py

@@ -134,6 +134,7 @@ class PackageScanner(ScanPlugin):
 
     required_plugins = ['scan:licenses']
 
+    run_order = 3
     sort_order = 3
 
     options = [

src/scancode/cli.py

@@ -1059,9 +1059,12 @@ def run_codebase_plugins(
     if verbose and plugins:
         echo_func(stage_msg % locals(), fg='green')
 
+    # Sort plugins by run_order, from low to high
+    sorted_plugins = sorted(plugins, key=lambda x: x.run_order)
+
     success = True
     # TODO: add progress indicator
-    for plugin in plugins:
+    for plugin in sorted_plugins:
         name = plugin.name
         plugin_start = time()
 

src/scancode/plugin_info.py

@@ -38,6 +38,7 @@ class InfoScanner(ScanPlugin):
         ('is_script', attr.ib(default=False, type=bool, repr=False)),
     ])
 
+    run_order = 0
     sort_order = 0
 
     options = [